[AXISCPP-967] WSDL2WS generate wrong code: no check for param->any1 will cause core dump

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6 Beta
• Fix Version/s: current (nightly)
• Component/s: WSDL processing - RPC

Environment

Platform:
        Linux fedora 3.0
Axis version:
        Server-side Axis C++ 1.6Beta
XML Parser Lib:
xersesc 2.6
WSDL2ws tool by using axis java 1.3
Client-side version Axis java 1.3
Http Server Version:
Apache 2.0.53
Tomcat 2.0.58

• Assignee: Nadir K. Amra
• Reporter: Michael Xiong
• Created: 25/Apr/06 14:46
• Updated: 31/Jan/07 09:06
• Resolved: 31/Jan/07 09:06

Description

[Error Statement]:
I have used AxisCPP1.6Beta version to generate TestDataInfo.cpp and Respond.cpp as the below:
TestDataInfo.cpp:
int Axis_Serialize_JobInfo(JobInfo* param, IWrapperSoapSerializer* pSZ, bool bArray = false)
{
... ...
pSZ->serializeAnyObject(param->any1);
... ...
}

and Respond.cpp:
int Axis_Serialize_Respond(Respond* param, IWrapperSoapSerializer* pSZ, bool bArray = false)
{
... ...
pSZ->serializeAnyObject(param->any1);
... ...
}

From the generated code, param->any1 is really an AnyType* pointer.
In some case, param->any1 will be NULL, but since there has no check for it before use, there will cause my generated server component core dump.

[solution]:
I have investigated the source code of AxisCPP/WSDL2Ws tool, and found that if I modify the following code at about line 682~694 in writeSerializeGlobalMethod method that belongs to BeanParamWriter (wsdl2ws/cpp/iteral) class, the generated code will become correct.
if (attribs[i].isAnyType())
{
anyCounter += 1;
//<mxiong debug 2006/4/25
writer.write("\tif (param->" + attribs[i].getParamName() + Integer.toString(anyCounter) + " != NULL)\n\t

{\n"); //>mxiong debug 2006/4/25 writer.write("\t\tpSZ->serializeAnyObject(param->any" + Integer.toString(anyCounter) +");\n"); //<mxiong debug 2006/4/25 writer.write("\t}

\n");
//>mxiong debug 2006/4/25
}

So I think it maybe a bug, could you like to check it ?