[AXISCPP-1055] Memory Leak in SoapSerializer::addOutputParam()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Fix Version/s: current (nightly)
• Component/s: Serialization
• Environment: Windows XP, VS6 with Compuware BoundsChecker
• Assignee: Unassigned
• Reporter: Ryan McCullough
• Created: 01/Oct/08 20:00
• Updated: 02/Oct/08 14:02
• Resolved: 02/Oct/08 14:02

Description

The function:
int SoapSerializer::addOutputParam( const AxisChar * pchName, void * pValue, XSDTYPE type)

contains a memory leak. xsdValue is not being deleted. Here is our proposed change:
/*

• Basic output parameter going to be serialized as an Element later
  */
  int SoapSerializer::
  addOutputParam( const AxisChar * pchName, void * pValue, XSDTYPE type)
  {
  IAnySimpleType* xsdValue = AxisUtils::createSimpleTypeObject(pValue, type);

Param * pParam = new Param();

if( !pParam)
return AXIS_FAIL;

pParam->m_Type = type;
pParam->m_sName = pchName;

pParam->setValue(type, xsdValue);

if( m_pSoapEnvelope &&
(m_pSoapEnvelope->m_pSoapBody) &&
(m_pSoapEnvelope->m_pSoapBody->m_pSoapMethod))
m_pSoapEnvelope->m_pSoapBody->m_pSoapMethod->addOutputParam( pParam);
else

{ delete xsdValue; delete pParam; return AXIS_FAIL; }

delete xsdValue;
return AXIS_SUCCESS; // Can it only be successful?
}