[AXIS2C-786] axiom_element_set_text() and other functions that do not make use of an axiom_element_t* object in its parameters

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Component/s: xml/soap
• Assignee: Dinesh Weerapurage
• Reporter: Edward Liu
• Created: 26/Nov/07 14:12
• Updated: 07/Apr/20 17:47
• Resolved: 13/Dec/07 04:16

Description

There are some functions, such as axiom_element_set_text(), that take in an axiom_element_t* object as one of its parameters, but does not make use of it (after viewing the Axis2-C source code). It is pretty inconvenient and unnecessary (in my opinion) to create an axiom_element_t* object, pass it into axiom_element_set_text(), and then free it, without using this object anywhere else except as an argument to a function that doesn't even use the object itself. I think that this creation and freeing of an axiom_element_t* object could be avoided. After talking with one of the developers, it is recommended that the axiom_element_t* argument be removed from those functions that have it as a parameter but make no use of it. I believe that passing NULL into these affected functions is a temporary workaround, not a permanent solution, for this issue. Thanks!