Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: Current (Nightly)
    • Fix Version/s: 1.0.0
    • Component/s: util
    • Labels:
      None

      Description

      I don't see how it's useful for axis2_string.h to provide macros like this:

      #define AXIS2_STRCMP(s1, s2) \
      axis2_strcmp(s1, s2)

      Why not have the clients use axis2_strcmp directly? The macro just uglifies code that uses it.

        Activity

        Hide
        Samisa Abeysinghe added a comment -

        I think all the methods in axis2_string.h do not need macros. We can drop all the macros safely.

        Show
        Samisa Abeysinghe added a comment - I think all the methods in axis2_string.h do not need macros. We can drop all the macros safely.
        Hide
        Samisa Abeysinghe added a comment -

        Macros has been dropped form sting header

        Show
        Samisa Abeysinghe added a comment - Macros has been dropped form sting header

          People

          • Assignee:
            Samisa Abeysinghe
            Reporter:
            James Clark
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development