Details
-
Task
-
Status: Closed
-
Minor
-
Resolution: Not A Problem
-
None
-
None
-
None
Description
While implementing additional tests for guththila, I noticed that guththila_token_list_init and guththila_token_list_grow allocate memory that does not appear to be used, with the exception of pushing addresses of empty elements onto the token stack. Since the functions to get/set tokens in the list directly call pop/push on the stack, it seems to me that the additional allocations are unnecessary. However, since I'm still getting familiar with the codebase, I don't want to make major changes based on assumptions.
This task is a reminder to go back and investigate whether these allocations are truly necessary, and if not, eliminate them.