Uploaded image for project: 'Axis2'
  1. Axis2
  2. AXIS2-5884

Change parameter "Description" to lower-case for service.xml.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.6
    • Fix Version/s: 1.8.0
    • Component/s: deployment
    • Labels:
      None

      Description

      Because of AXIS2-5881 I had a look at my own Axis2 services and recognized that their description is wrong and is the service name instead of what is defined in the service.xml file. The problem was simply using "description" instead of "Description" and the latter is documented, so I must have simply overlooked the different spelling.

      http://axis.apache.org/axis2/java/core/docs/axis2config.html#Service_Configuration

      So why not change this configuration to lower case to be in-line with all other configs in this file and with most other configs as well?

      Searching through the Axis2 codebase reveals that "description" is hard coded at some places already and I even found service.xml files in tests where "description" is used, so are wrong in theory. The only environment where "Description" seems to make sense is module.xml, which uses "InFlow", "OutFlow" etc. as well.

      So we can change the value of TAG_DESCRIPTION to be lower case and hard-code something for modules or keep TAG_DESCRIPTION as it is and hard code a lower case variant for service.xml or simply use "description" for all, which wouldn't like that right in module.xml anymore...

      What do you prefer?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              tschoening Thorsten Schöning
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: