[AXIS2-5868] Small logic error in axis2-kernel ParameterIncludeImpl.java

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.6
• Fix Version/s: 1.7.7
• Component/s: kernel
• Assignee: Unassigned
• Reporter: Jeff Thomas
• Created: 17/Aug/17 12:02
• Updated: 21/Aug/17 21:14
• Resolved: 21/Aug/17 21:14

Description

Found small bug in the axis2-kernel ParameterIncludeImpl.java.

The "parameters.put(param.getName(), param)" is always performed twice.

It looks like a copy/paste mistake when moving the "put" into the try block, the original line was not removed and remains outside of the try block. In the worst-case scenario, the ConcurrentModificationException would not be caught as expected.

public void addParameter(Parameter param) {
  if (param != null) {
    synchronized (parameters) {
      parameters.put(param.getName(), param);
      try {
        parameters.put(param.getName(), param);
      } catch (ConcurrentModificationException cme) {
        ...
      }
  }