[AXIS2-5824] [Transport][JMS] Change thrown exception

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.7.4
• Fix Version/s: 1.7.5
• Component/s: JMS transport
• Flags: Patch
• Assignee: Andreas Veithen
• Reporter: Ziborov Egor
• Created: 04/Dec/16 19:24
• Updated: 19/Dec/16 17:02
• Resolved: 19/Dec/16 17:02

Description

When we tries to lookup some destination for example "my.loc.dest" and it doesn't exist than we handle exception with message:
While trying to lookup 'dynamicQueues.local.rmk.access.SMKtoRMK.dq' didn't find subcontext 'dynamicQueues'. Resolved '' (for Weblogic)

I'd offer to change JMSUtils.lookupDestination from:

    public static Destination lookupDestination(Context context, String destinationName,
                                                String destinationType) throws NamingException {

        if (destinationName == null) {
            return null;
        }

        try {
            return JMSUtils.lookup(context, Destination.class, destinationName);
        } catch (NameNotFoundException e) {
            try {
                return JMSUtils.lookup(context, Destination.class,
                    (JMSConstants.DESTINATION_TYPE_TOPIC.equalsIgnoreCase(destinationType) ?
                        "dynamicTopics/" : "dynamicQueues/") + destinationName);
            } catch (NamingException x) {
                log.warn("Cannot locate destination : " + destinationName);
                throw x;
            }
        } catch (NamingException e) {
            log.warn("Cannot locate destination : " + destinationName, e);
            throw e;
        }
    }

to:

    public static Destination lookupDestination(Context context, String destinationName,
                                                String destinationType) throws NamingException {

        if (destinationName == null) {
            return null;
        }

        try {
            return JMSUtils.lookup(context, Destination.class, destinationName);
        } catch (NameNotFoundException e) {
            try {
                return JMSUtils.lookup(context, Destination.class,
                    (JMSConstants.DESTINATION_TYPE_TOPIC.equalsIgnoreCase(destinationType) ?
                        "dynamicTopics/" : "dynamicQueues/") + destinationName);
            } catch (NamingException x) {
                log.warn("Cannot locate destination : " + destinationName);
                throw e;
            }
        } catch (NamingException e) {
            log.warn("Cannot locate destination : " + destinationName, e);
            throw e;
        }
    }