Axis2
  1. Axis2
  2. AXIS2-5478

documantation has wrong config example

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.7.0
    • Component/s: documentation
    • Labels:
    • Environment:
      all

      Description

      http://axis.apache.org/axis2/java/core/tools/maven-plugins/maven-wsdl2code-plugin.html
      this example is incorrect the config part should be moved up.
      so this:

      <build>
      <plugins>
      <plugin>
      <groupId>org.apache.axis2</groupId>
      <artifactId>axis2-wsdl2code-maven-plugin</artifactId>
      <version>1.4</version>
      <executions>
      <execution>
      <goals>
      <goal>wsdl2code</goal>
      </goals>
      <configuration>
      <packageName>com.foo.myservice</packageName>
      <wsdlFile>src/main/wsdl/myservice.wsdl</wsdlFile>
      <databindingName>xmlbeans</databindingName>
      </configuration>
      </execution>
      </executions>
      </plugin>
      </plugins>
      </build>

      should be this:

      <build>
      <plugins>
      <plugin>
      <groupId>org.apache.axis2</groupId>
      <artifactId>axis2-wsdl2code-maven-plugin</artifactId>
      <version>1.4</version>
      <configuration>
      <packageName>com.foo.myservice</packageName>
      <wsdlFile>src/main/wsdl/myservice.wsdl</wsdlFile>
      <databindingName>xmlbeans</databindingName>
      </configuration>

      <executions>
      <execution>
      <goals>
      <goal>wsdl2code</goal>
      </goals>
      </execution>
      </executions>
      </plugin>
      </plugins>
      </build>

      and the version number could be uped

      1. AXIS2-5478.patch
        2 kB
        Kishanthan Thangarajah

        Activity

        Hide
        Kishanthan Thangarajah added a comment -

        Yes, the documentation is indeed incorrect. That would result in an error like the below, where the plugin fails to get the configuration values. I also came across this.

        [ERROR] Failed to execute goal org.apache.axis2:axis2-wsdl2code-maven-plugin:1.6.2:wsdl2code (default-cli) on project calculator: The parameters 'packageName' for goal org.apache.axis2:axis2-wsdl2code-maven-plugin:1.6.2:wsdl2code are missing or invalid -> [Help 1]

        The configuration section should not be inside the execution section and it should be moved out. And yes, the version also can be updated to 1.6.2, which is the latest.

        The attached patch will add the required changes to the documentation of wsdl2code maven plugin.

        Show
        Kishanthan Thangarajah added a comment - Yes, the documentation is indeed incorrect. That would result in an error like the below, where the plugin fails to get the configuration values. I also came across this. [ERROR] Failed to execute goal org.apache.axis2:axis2-wsdl2code-maven-plugin:1.6.2:wsdl2code (default-cli) on project calculator: The parameters 'packageName' for goal org.apache.axis2:axis2-wsdl2code-maven-plugin:1.6.2:wsdl2code are missing or invalid -> [Help 1] The configuration section should not be inside the execution section and it should be moved out. And yes, the version also can be updated to 1.6.2, which is the latest. The attached patch will add the required changes to the documentation of wsdl2code maven plugin.
        Hide
        Sagara Gunathunga added a comment -

        Patch applied in r1502747.

        Show
        Sagara Gunathunga added a comment - Patch applied in r1502747.
        Hide
        Hudson added a comment -

        UNSTABLE: Integrated in Axis2 #2402 (See https://builds.apache.org/job/Axis2/2402/)
        Applied patch for AXIS2-5478 (sagara: rev 1502747)

        • /axis/axis2/java/core/trunk/src/site/xdoc/tools/maven-plugins/maven-wsdl2code-plugin.xml
        Show
        Hudson added a comment - UNSTABLE: Integrated in Axis2 #2402 (See https://builds.apache.org/job/Axis2/2402/ ) Applied patch for AXIS2-5478 (sagara: rev 1502747) /axis/axis2/java/core/trunk/src/site/xdoc/tools/maven-plugins/maven-wsdl2code-plugin.xml

          People

          • Assignee:
            Kishanthan Thangarajah
            Reporter:
            tibi
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development