[AXIS2-5474] DefaultSchemaGenerator : properly handle failure when a bean property has no getReadMethod()

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.6.2
• Component/s: kernel
• Labels: patch
• Assignee: Unassigned
• Reporter: Philippe Le Berre
• Created: 08/Jan/13 09:13
• Updated: 03/Jan/18 11:54
• Resolved: 03/Jan/18 11:54

Description

Deployment of service (aar file) might failed with :

Caused by: org.apache.axis2.deployment.DeploymentException: The following error occurred during schema generation: null
at org.apache.axis2.deployment.ServiceBuilder.populateService(ServiceBuilder.java:396)
... 35 more
Caused by: java.lang.NullPointerException
at org.apache.axis2.description.java2wsdl.DefaultSchemaGenerator.generateSchema(DefaultSchemaGenerator.java:606)
at org.apache.axis2.description.java2wsdl.DefaultSchemaGenerator.generateSchemaTypeforNameCommon(DefaultSchemaGenerator.java:1092)

In which the getReadMethod() is returning null for a bean property, thus to make it more friendly and avoid anyone loosing time on such things :

— DefaultSchemaGenerator.java 2013-01-08 10:09:33.000000000 +0100
+++ DefaultSchemaGenerator.java.new 2013-01-08 10:09:17.000000000 +0100
@@ -603,6 +603,9 @@
String propertyName = property.getName();
if (!property.getName().equals("class") && (property.getPropertyType() != null)) {
if ((beanExcludeInfo == null) || !beanExcludeInfo.isExcludedProperty(propertyName)) {
+ if (property.getReadMethod() == null)

{ + throw new Exception("Failed property ("+property.getName()+") has no getReadMethod() method in Class ("+javaType+")"); + }

Type genericFieldType = property.getReadMethod().getGenericReturnType();
if(genericFieldType instanceof ParameterizedType){
ParameterizedType aType = (ParameterizedType) genericFieldType;