[AXIS2-5300] org.apache.axis2.json.AbstractJSONOMBuilder hangs when JSON has wrong format

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.2
• Fix Version/s: 1.6.3, 1.7.0
• Component/s: json
• Environment: Apache tomcat 7.0.25; Ubuntu 64Bit 11.10
• Assignee: Andreas Veithen
• Reporter: Matthias Gerber
• Created: 25/Apr/12 11:55
• Updated: 14/Nov/12 17:02
• Resolved: 02/May/12 19:40

Description

org.apache.axis2.json.AbstractJSONOMBuilder hangs when JSON has wrong format:

Code loping through reader at line 119 and 135 to get localName should check for end of stream.
Otherwise the code cycles for ever if the string to parse does not contain a ":"

Code as it is at the moment:

118 char temp = (char)reader.read();
119 while (temp != ':') {
120 if (temp != ' ' && temp != '{' && temp != '\n' && temp != '\r' && temp != '\t')

{ 121 localName += temp; 122 }
123 temp = (char)reader.read();
124 }


Code as it should be (or something like that):
int t = reader.read();
118 char temp = (char)t;
119 while (temp != ':' && t >= 0) {
120 if (temp != ' ' && temp != '{' && temp != '\n' && temp != '\r' && temp != '\t') {121 localName += temp;122 }

t = reader.read();
123 temp = (char)t;
124 }

And maybe some error handling if end of stream is reached.