[AXIS2-5125] JSONOMBuilder drives system to an indefinite loop

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.5.5
• Fix Version/s: 1.6.3, 1.7.0
• Component/s: json
• Labels: axis2 json
• Environment: Mac OS X 10.6.8, JVM 1.6.0_26
• Assignee: Shameera
• Reporter: Han Gun
• Created: 20/Aug/11 06:02
• Updated: 14/Nov/12 17:03
• Resolved: 13/Feb/12 10:35

Description

processDocument method in JSONOMBuilder has the following loop:

char temp = inputStream.read();
while (temp != ':') {
...
}

This will lead to an indefinite loop in case a non-json or empty json {} payload is posted to the servlet. Actually any payload without colon character ':' should reproduce the same problem.

I fixed it by changing the variable type temp into int and checking if the stream has more elements as a guard condition.

int temp = inputStream.read();
while (temp > -1 && temp != ':') {
if (temp != ' ' && temp != '{')

{ localName += (char)temp; }

temp = inputStream.read();
}

Issue Links

• is duplicated by: AXIS2-5440 Tomcat using 100% CPU when application/json (JSONMessageFormatter) is used