Axis2
  1. Axis2
  2. AXIS2-4888

The org.apache.axis2:axis2 Maven artifact should not have a classifier

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.5.4, 1.6.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      N/A

      Description

      The jar at http://repo2.maven.org/maven2/org/apache/axis2/axis2/1.5.3/ is badly name.
      It's jar.jar and should be .jar

        Activity

        Hide
        Andreas Veithen added a comment -

        Analysis:

        Just before the 1.5.3 I added an assembly (src/main/assembly/dists.xml) that produces the directory structure (distributions+MD5+PGP) that needs to be deployed to www.apache.org/dist. This assembly uses $

        {settings.localRepository}

        because the checksum and signature files can only be retrieved from the local repository. This property is only supported in maven-assembly-plugin >= 2.2. However, starting with version 2.2, maven-assembly-plugin uses a different approach to generate artifacts without classifiers [1]. After upgrading to 2.2 for the 1.5.3 release, the axis2.jar got a classifier ('jar') while in previous releases it had no classifier.

        It should be noted that it is in general not a good idea to use org.apache.axis2:axis2 as a Maven dependency because it doesn't declare its dependencies. Instead, individual modules (such as axis2-kernel) should be used as dependencies. axis2.jar is useful mainly for projects that don't use Maven, and for these projects, the fact that there is an additional '-jar' in the name is not a big issue.

        [1] http://maven.apache.org/plugins/maven-assembly-plugin/faq.html#required-classifiers

        Show
        Andreas Veithen added a comment - Analysis: Just before the 1.5.3 I added an assembly (src/main/assembly/dists.xml) that produces the directory structure (distributions+MD5+PGP) that needs to be deployed to www.apache.org/dist. This assembly uses $ {settings.localRepository} because the checksum and signature files can only be retrieved from the local repository. This property is only supported in maven-assembly-plugin >= 2.2. However, starting with version 2.2, maven-assembly-plugin uses a different approach to generate artifacts without classifiers [1] . After upgrading to 2.2 for the 1.5.3 release, the axis2.jar got a classifier ('jar') while in previous releases it had no classifier. It should be noted that it is in general not a good idea to use org.apache.axis2:axis2 as a Maven dependency because it doesn't declare its dependencies. Instead, individual modules (such as axis2-kernel) should be used as dependencies. axis2.jar is useful mainly for projects that don't use Maven, and for these projects, the fact that there is an additional '-jar' in the name is not a big issue. [1] http://maven.apache.org/plugins/maven-assembly-plugin/faq.html#required-classifiers
        Hide
        Andreas Veithen added a comment -

        Fixed by r1036624 on the trunk and r1036625 on the 1.5 branch.

        Show
        Andreas Veithen added a comment - Fixed by r1036624 on the trunk and r1036625 on the 1.5 branch.
        Hide
        David J. M. Karlsen added a comment -

        This fix does not however fix the current 1.5.3 pushed out.
        Could you push out an jar with the correct filename?
        This shouldn't be a problem as the pom will match and we're not overwriting any files.

        Show
        David J. M. Karlsen added a comment - This fix does not however fix the current 1.5.3 pushed out. Could you push out an jar with the correct filename? This shouldn't be a problem as the pom will match and we're not overwriting any files.
        Hide
        Andreas Veithen added a comment -

        A fix cannot be applied to an already released version.

        Show
        Andreas Veithen added a comment - A fix cannot be applied to an already released version.
        Hide
        David J. M. Karlsen added a comment -

        In this case I think it can - because it would not change any of the released artifacts - it's a simple copy of the one file to another one w/o the duplicate .jar ending.
        If a 1.5.4 shows up with this simple fix it would not be a problem though.

        Show
        David J. M. Karlsen added a comment - In this case I think it can - because it would not change any of the released artifacts - it's a simple copy of the one file to another one w/o the duplicate .jar ending. If a 1.5.4 shows up with this simple fix it would not be a problem though.
        Hide
        Andreas Veithen added a comment -

        The fix is on the 1.5 branch and will therefore be available in 1.5.4.

        Show
        Andreas Veithen added a comment - The fix is on the 1.5 branch and will therefore be available in 1.5.4.

          People

          • Assignee:
            Andreas Veithen
            Reporter:
            David J. M. Karlsen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development