[AXIS2-4463] Unreachable code in JAXBAttachmentUnmarshaller

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: jaxws
• Assignee: Rich Scheuerle
• Reporter: Andreas Veithen
• Created: 15/Aug/09 11:22
• Updated: 08/Sep/09 18:55
• Resolved: 08/Sep/09 18:55

Description

While reviewing some code, I noticed that org.apache.axis2.datasource.jaxb.JAXBAttachmentUnmarshaller contains unreachable code. There are two places where the following if statement is used:

if (xmlStreamReader instanceof OMXMLStreamReader) {
...
}

"xmlStreamReader" is an attribute of JAXBAttachmentUnmarshaller, but this attribute is never initialized and remains null (this is obviously a bug; see code in the constructor). Since "null instanceof X" is always false, the code inside the if statement is unreachable.

Since this code is related to XOP/MTOM processing, I'm wondering how it is possible that MTOM actually works in JAX-WS (does it?). Also it would be interesting to analyze why this issue doesn't trigger any test failure.

Issue Links

• is related to: AXIOM-202 OMStaXWrapper Does Not Support Optimized OMText as an XOP:Include