Axis2
  1. Axis2
  2. AXIS2-4314

service references are not completely removed in AxisConfiguration

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3, 1.4, 1.4.1, 1.5
    • Fix Version/s: 1.6.2, 1.7.0
    • Component/s: kernel
    • Labels:
      None

      Description

      I reopen issue AXIS2-3870, because the fix is half baked. It does a proper clean-up job for AxisConfiguration#removeServiceGroup but omits AxisConfiguration#removeService.

        Issue Links

          Activity

          Hide
          Alexis Midon added a comment - - edited

          This patch factorizes in a method the steps required to clean up the references to a given AxisService.
          This method is then invoked from AxisConfiguration#removeServiceGroup and AxisConfiguration#removeService.

          Patch is base on the latest 1.5 branch.

          Show
          Alexis Midon added a comment - - edited This patch factorizes in a method the steps required to clean up the references to a given AxisService. This method is then invoked from AxisConfiguration#removeServiceGroup and AxisConfiguration#removeService. Patch is base on the latest 1.5 branch.
          Hide
          Deepal Jayasinghe added a comment -

          Seems like the patch is outdated, could you please modify that and attach again.

          Show
          Deepal Jayasinghe added a comment - Seems like the patch is outdated, could you please modify that and attach again.
          Hide
          Matthias Gaiser added a comment -

          Is this already fixed? In which version? I experienced the same problem in Axis2 version 1.5.
          I created new ServiceClients for each request and the AxisServices did not get deleted in the AxisConfiguration at all, also not after calling ServiceClient.cleanup().

          Show
          Matthias Gaiser added a comment - Is this already fixed? In which version? I experienced the same problem in Axis2 version 1.5. I created new ServiceClients for each request and the AxisServices did not get deleted in the AxisConfiguration at all, also not after calling ServiceClient.cleanup().
          Hide
          Amila Chinthaka Suriarachchi added a comment -

          can you please check with the current trunk[1]. Do you have the problem there as well?

          [1] https://svn.apache.org/repos/asf/axis/axis2/java/core/trunk

          Show
          Amila Chinthaka Suriarachchi added a comment - can you please check with the current trunk [1] . Do you have the problem there as well? [1] https://svn.apache.org/repos/asf/axis/axis2/java/core/trunk
          Hide
          Franco Nero added a comment -

          im using Axis2.1.4.1 and i'm encountering this and other issues(e.g.mem leak). where can i get a patched/snapshot build as i can only use version that can run on java jdk 1.4. I have been looking but have not found any.

          Show
          Franco Nero added a comment - im using Axis2.1.4.1 and i'm encountering this and other issues(e.g.mem leak). where can i get a patched/snapshot build as i can only use version that can run on java jdk 1.4. I have been looking but have not found any.
          Hide
          Rodmar added a comment -

          HI,

          We had a lot of memory leak problem in AxisService class. Memory growth up to 4gb in a multi thread environment in only three days of usage (40,000 invocations of WS). We're using axis2 1.4.1.

          We discovered that the leak was instantiating AxisService class once per request. Therefore we changed to a Singleton usage of AxisService (used through ThreadLocal to still support multi threating). This solved memory leak problems.

          Cheers.

          Show
          Rodmar added a comment - HI, We had a lot of memory leak problem in AxisService class. Memory growth up to 4gb in a multi thread environment in only three days of usage (40,000 invocations of WS). We're using axis2 1.4.1. We discovered that the leak was instantiating AxisService class once per request. Therefore we changed to a Singleton usage of AxisService (used through ThreadLocal to still support multi threating). This solved memory leak problems. Cheers.
          Hide
          Christian Brignani added a comment - - edited

          I found the same problem in my configuration, follows some details taken from the application server:

          Class Name | Shallow Heap | Retained Heap
          -------------------------------------------------------------------------------------
          org.apache.axis2.engine.AxisConfiguration @ 0x2f64fc88| 168 | 18,476,880
          -------------------------------------------------------------------------------------

          in which main memory is occupied by:

          Class Name | Shallow Heap | Retained Heap
          ----------------------------------------------------------------------------
          allEndpoints java.util.Hashtable @ 0x2f651290| 40 | 17,728,208
          ----------------------------------------------------------------------------

          due 376 "endpoint":

          Type| Name | Value
          --------------------
          int | count | 376
          --------------------

          Since we need to use Java 1.4, is there any possibility to fix Axis2 1.4.x ? Have someone tried the patch suggested by Alex?
          I see there are no plans for Axis2 1.4.2, could anyone confirm this?

          thanks
          Christian

          Show
          Christian Brignani added a comment - - edited I found the same problem in my configuration, follows some details taken from the application server: Class Name | Shallow Heap | Retained Heap ------------------------------------------------------------------------------------- org.apache.axis2.engine.AxisConfiguration @ 0x2f64fc88| 168 | 18,476,880 ------------------------------------------------------------------------------------- in which main memory is occupied by: Class Name | Shallow Heap | Retained Heap ---------------------------------------------------------------------------- allEndpoints java.util.Hashtable @ 0x2f651290| 40 | 17,728,208 ---------------------------------------------------------------------------- due 376 "endpoint": Type| Name | Value -------------------- int | count | 376 -------------------- Since we need to use Java 1.4, is there any possibility to fix Axis2 1.4.x ? Have someone tried the patch suggested by Alex? I see there are no plans for Axis2 1.4.2, could anyone confirm this? thanks Christian
          Hide
          Andrea Tanzini added a comment -

          Any news about how to fix the bug?

          Show
          Andrea Tanzini added a comment - Any news about how to fix the bug?
          Hide
          Erik Ostermueller added a comment -

          We have seen this exact problem with 1.4, 1.5 and 1.6.

          Deepal Jayasinghe wrote
          >>Seems like the patch is outdated, could you please modify that and attach again.
          There is no mention that anyone has followed up on this.
          Could someone try to re-do this patch with 1.6?

          Show
          Erik Ostermueller added a comment - We have seen this exact problem with 1.4, 1.5 and 1.6. Deepal Jayasinghe wrote >>Seems like the patch is outdated, could you please modify that and attach again. There is no mention that anyone has followed up on this. Could someone try to re-do this patch with 1.6?
          Hide
          Nikhil Joseph added a comment -

          Hi all,

          Any news on how to fix this problem?

          Show
          Nikhil Joseph added a comment - Hi all, Any news on how to fix this problem?
          Hide
          Sagara Gunathunga added a comment -

          Fixed in r1243831.

          Show
          Sagara Gunathunga added a comment - Fixed in r1243831.
          Hide
          Hudson added a comment -

          Integrated in Axis2 #1266 (See https://builds.apache.org/job/Axis2/1266/)
          Applied patch for AXIS2-4314 with some modifications. (Revision 1243831)

          Result = FAILURE
          sagara :
          Files :

          • /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/engine/AxisConfiguration.java
          Show
          Hudson added a comment - Integrated in Axis2 #1266 (See https://builds.apache.org/job/Axis2/1266/ ) Applied patch for AXIS2-4314 with some modifications. (Revision 1243831) Result = FAILURE sagara : Files : /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/engine/AxisConfiguration.java
          Hide
          Nikhil Joseph added a comment -

          Can you give some details on the fix? , perhaps make it available in 1.4 , 1.6.2 seems too far

          Show
          Nikhil Joseph added a comment - Can you give some details on the fix? , perhaps make it available in 1.4 , 1.6.2 seems too far
          Hide
          Sagara Gunathunga added a comment -

          1.4 is a no longer active branch these improvements will ship with Axis2 1.6.2 version.

          Show
          Sagara Gunathunga added a comment - 1.4 is a no longer active branch these improvements will ship with Axis2 1.6.2 version.

            People

            • Assignee:
              Sagara Gunathunga
              Reporter:
              Alexis Midon
            • Votes:
              3 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development