[AXIS2-2516] Poor performance of File Caching caused by PartOnFile

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Component/s: om
• Assignee: Nanayakkara Kuruppuge Thilina Gunarathne
• Reporter: Liyu Yi
• Created: 12/Apr/07 17:26
• Updated: 13/Apr/07 05:08
• Resolved: 13/Apr/07 03:11

Description

I noticed that the performance of "File Caching" is not great, and I believe it is due to the implementation of the constructor of "org.apache.axiom.attachments.PartOnFile" which reads and writes the inputSteam byte-by-byte (see the snippets below). Can we simply apply some buffering to improve it?

public PartOnFile(PushbackFilePartInputStream inStream, String repoDir) {
...
cacheFile = File.createTempFile("Axis2", ".att",
repoDirFile);

FileOutputStream fileOutStream = new FileOutputStream(cacheFile);
int value;
value = parseTheHeaders(inStream);
fileOutStream.write(value);
while (!inStream.getBoundaryStatus()) {
value = inStream.read();
if (!inStream.getBoundaryStatus())

{ fileOutStream.write(value); }

}

fileOutStream.flush();
fileOutStream.close();
} catch (IOException e)

{ throw new OMException("Error creating temporary File.", e); }

}