[AXIS-2019] Bug in getElementsByTagNameNS() method of SOAPDocumentImpl class

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: beta-2
• Component/s: SAAJ
• Assignee: Unassigned
• Reporter: Ashutosh Shahi
• Created: 27/May/05 17:50
• Updated: 28/May/05 00:34
• Resolved: 28/May/05 00:34

Description

I found a bug in getElementByTagName and getElementByTagNameNS methods of SOAPDocumentImpl class. he header and body parts call the above methods of MessageElement, but the result is never combined, we just have separate return statements for header and body parts. The result from both of them be combined and then returned. Am posting the relevant code, the patch will follow:

if (soapPart != null) {
SOAPEnvelope soapEnv =
(org.apache.axis.message.SOAPEnvelope) soapPart
.getEnvelope();
SOAPHeader header =
(org.apache.axis.message.SOAPHeader) soapEnv.getHeader();
if (header != null)

{ return header.getElementsByTagName(localName); }

SOAPBody body =
(org.apache.axis.message.SOAPBody) soapEnv.getBody();
if (body != null)

{ return body.getElementsByTagName(localName); }

}
return null;

We should combine the result of header and body in a NodeList and then return.

Ashutosh