[AXIS-1738] Object Comparison in SOAPHeader.getHeadersByActors(...) seems to be incorrect.

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.2
• Component/s: SAAJ
• Environment: Windows 2000 Professional. JDK 1.4.2_03 mixed mode. JUnit 3.8
• Assignee: Unassigned
• Reporter: Devang Mehta
• Created: 25/Dec/04 06:35
• Updated: 25/Dec/04 06:53

Description

Hi,

While going through the Code of SOAPHeader.java file for the method getHeadersByActor(ArrayList actors) I observed that
the compliance check for SOAP1.2 is done using the == operator. When i executed the attached JUnit for the same, the JUnit TC failed.

On analyzing the same i observed that the failure was because of the == comparison of objects. I modified the code to replace the == comparison with
instanceof comparison the TC has passed.

I am attaching the HTML diff (using CSDiff utility) of the SOAPHeader File and also the JUnit TC

The base code of SOAPHeader file is the one present in Axis 1.2RC2 code.

P.S. I have found similar such occurences in the RC2 code in other classes too. If I am right then you might need to update even those files. I will be able to list the filenames and post it here or on the developers mailing list.

Regards,
Devang.