Axiom
  1. Axiom
  2. AXIOM-397

OMChildrenNamespaceIterator.isEqual ignores second parameter

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.9, 1.2.12
    • Fix Version/s: 1.2.13
    • Component/s: DOOM, LLOM
    • Labels:
      None
    • Environment:
      N/A

      Description

      Whilst debugging an issue with SOAPHeader.getChildrenWithNamespaceURI() we discovered that OMChildrenNamespaceIterator.isEqual() ignores the "currentQName" parameter. This renders it rather useless. We found on 1.2.9, but have verified it's not fixed in 1.2.12 and can't see an existing issue for it in any of the unreleased versions:

      public boolean isEqual(QName searchQName, QName currentQName)

      { return searchQName.getNamespaceURI().equals(searchQName.getNamespaceURI()); }

      should read:

      public boolean isEqual(QName searchQName, QName currentQName)

      { return searchQName.getNamespaceURI().equals(currentQName.getNamespaceURI()); }

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in ws-axiom-trunk #685 (See https://builds.apache.org/job/ws-axiom-trunk/685/)
          AXIOM-397: Fixed the broken getChildrenWithNamespaceURI method.

          veithen :
          Files :

          • /webservices/commons/trunk/modules/axiom/modules/axiom-common-impl/src/main/java/org/apache/axiom/om/impl/common/OMChildrenNamespaceIterator.java
          • /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/OMTestSuiteBuilder.java
          • /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestGetChildrenWithNamespaceURI.java
          Show
          Hudson added a comment - Integrated in ws-axiom-trunk #685 (See https://builds.apache.org/job/ws-axiom-trunk/685/ ) AXIOM-397 : Fixed the broken getChildrenWithNamespaceURI method. veithen : Files : /webservices/commons/trunk/modules/axiom/modules/axiom-common-impl/src/main/java/org/apache/axiom/om/impl/common/OMChildrenNamespaceIterator.java /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/OMTestSuiteBuilder.java /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestGetChildrenWithNamespaceURI.java

            People

            • Assignee:
              Andreas Veithen
              Reporter:
              Simon Matic Langford
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development