Uploaded image for project: 'Axiom'
  1. Axiom
  2. AXIOM-397

OMChildrenNamespaceIterator.isEqual ignores second parameter

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.9, 1.2.12
    • Fix Version/s: 1.2.13
    • Component/s: DOOM, LLOM
    • Labels:
      None
    • Environment:
      N/A

      Description

      Whilst debugging an issue with SOAPHeader.getChildrenWithNamespaceURI() we discovered that OMChildrenNamespaceIterator.isEqual() ignores the "currentQName" parameter. This renders it rather useless. We found on 1.2.9, but have verified it's not fixed in 1.2.12 and can't see an existing issue for it in any of the unreleased versions:

      public boolean isEqual(QName searchQName, QName currentQName)

      { return searchQName.getNamespaceURI().equals(searchQName.getNamespaceURI()); }

      should read:

      public boolean isEqual(QName searchQName, QName currentQName)

      { return searchQName.getNamespaceURI().equals(currentQName.getNamespaceURI()); }

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build axiom-1.2.x #52 (See https://builds.apache.org/job/axiom-1.2.x/52/)
          AXIOM-397: Merge r1791831 to the 1.2 branch. (veithen: rev 1791832)

          • (edit) axiom
          • (edit) axiom/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenNamespaceIterator.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build axiom-1.2.x #52 (See https://builds.apache.org/job/axiom-1.2.x/52/ ) AXIOM-397 : Merge r1791831 to the 1.2 branch. (veithen: rev 1791832) (edit) axiom (edit) axiom/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenNamespaceIterator.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build axiom-trunk #2826 (See https://builds.apache.org/job/axiom-trunk/2826/)
          Apply the fix for AXIOM-397 to the deprecated copy of OMChildrenNamespaceIterator in axiom-compat as well. (veithen: rev 1791831)

          • (edit) axiom/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenNamespaceIterator.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build axiom-trunk #2826 (See https://builds.apache.org/job/axiom-trunk/2826/ ) Apply the fix for AXIOM-397 to the deprecated copy of OMChildrenNamespaceIterator in axiom-compat as well. (veithen: rev 1791831) (edit) axiom/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenNamespaceIterator.java
          Hide
          lifove JC added a comment -

          Hi
          In a recent GitHub mirror for webservices-axiom (commit id: 0214fd05425499c74f8462535d03279330059f7e), this problem is still there in this path: axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenNamespaceIterator.java

           45     @Override
           46     public boolean isEqual(QName searchQName, QName currentQName) {
           47         return searchQName.getNamespaceURI().equals(searchQName.getNamespaceURI());
           48     }
          

          I was wondering if this should be fixed or this is just intended. Thanks!

          Show
          lifove JC added a comment - Hi In a recent GitHub mirror for webservices-axiom (commit id: 0214fd05425499c74f8462535d03279330059f7e), this problem is still there in this path: axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMChildrenNamespaceIterator.java 45 @Override 46 public boolean isEqual(QName searchQName, QName currentQName) { 47 return searchQName.getNamespaceURI().equals(searchQName.getNamespaceURI()); 48 } I was wondering if this should be fixed or this is just intended. Thanks!
          Hide
          hudson Hudson added a comment -

          Integrated in ws-axiom-trunk #685 (See https://builds.apache.org/job/ws-axiom-trunk/685/)
          AXIOM-397: Fixed the broken getChildrenWithNamespaceURI method.

          veithen :
          Files :

          • /webservices/commons/trunk/modules/axiom/modules/axiom-common-impl/src/main/java/org/apache/axiom/om/impl/common/OMChildrenNamespaceIterator.java
          • /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/OMTestSuiteBuilder.java
          • /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestGetChildrenWithNamespaceURI.java
          Show
          hudson Hudson added a comment - Integrated in ws-axiom-trunk #685 (See https://builds.apache.org/job/ws-axiom-trunk/685/ ) AXIOM-397 : Fixed the broken getChildrenWithNamespaceURI method. veithen : Files : /webservices/commons/trunk/modules/axiom/modules/axiom-common-impl/src/main/java/org/apache/axiom/om/impl/common/OMChildrenNamespaceIterator.java /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/OMTestSuiteBuilder.java /webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/om/element/TestGetChildrenWithNamespaceURI.java

            People

            • Assignee:
              veithen Andreas Veithen
              Reporter:
              eswdd Simon Matic Langford
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development