Uploaded image for project: 'Axiom'
  1. Axiom
  2. AXIOM-394

Axiom should not allow creation of SOAPFaultSubCode elements for SOAP 1.1

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.2.12
    • 1.2.15
    • API
    • None

    Description

      Axiom currently allows creating and adding SOAPFaultSubCode elements to SOAP 1.1 faults, although the concept of subcode doesn't exist in SOAP 1.1. To avoid generating invalid SOAP messages, the SOAP11FaultCodeImpl classes in LLOM and DOOM override the internalSerialize method to silently skip the SOAPFaultSubCode node. However, the element is still visible when requesting an XMLStreamReader or a SAXSource.

      This can be shown using the following code:

      SOAPFactory factory = OMAbstractFactory.getSOAP11Factory();
      SOAPFault fault = factory.createSOAPFault();
      SOAPFaultCode code = factory.createSOAPFaultCode(fault);
      factory.createSOAPFaultSubCode(code);
      System.out.println("Using serialize:");
      fault.serialize(System.out);
      System.out.println();
      System.out.println("Using pull parser:");
      XMLStreamWriter writer = StAXUtils.createXMLStreamWriter(System.out);
      new StreamingOMSerializer().serialize(fault.getXMLStreamReader(), writer);
      writer.close();
      System.out.println();
      System.out.println("Using SAXSource:");
      TransformerFactory.newInstance().newTransformer().transform(fault.getSAXSource(true), new StreamResult(System.out));

      The output is:

      Using serialize:
      <soapenv:Fault xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"><faultcode></faultcode></soapenv:Fault>
      Using pull parser:
      <soapenv:Fault xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"><faultcode><Subcode /></faultcode></soapenv:Fault>
      Using SAXSource:
      <?xml version="1.0" encoding="UTF-8"?><soapenv:Fault xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"><faultcode><Subcode/></faultcode></soapenv:Fault>

      This behavior is inconsistent and Axiom should forbid creating SOAPFaultSubCode objects for SOAP 1.1.

      Attachments

        Activity

          People

            veithen Andreas Veithen
            veithen Andreas Veithen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: