Axiom
  1. Axiom
  2. AXIOM-300

Define a common superinterface for SOAPFaultCode and SOAPFaultSubCode

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.9
    • Component/s: None
    • Labels:
      None

      Description

      Hi everybody,
      recently I have done some research on how SOAP Faults are generated.
      If you look at both SOAPFaultCode and SOAPFaultSubCode it becomes obvious that SOAPFaultCode and SOAPFaultSubCode implementation can be refactored. My proposal is that both they can extend a common interface and thus make them more natural and reusable. No need of casting anymore.

      The fixes are applied to the current mail.

      Looking forward for your comments on this.

      thank you in advance,
      Dobri

      1. SOAPFaultSubCode_patch.patch
        1.0 kB
        Dobri Kitipov
      2. SOAPFaultCode_patch.patch
        0.8 kB
        Dobri Kitipov
      3. SOAPFaultClassifier.java
        0.7 kB
        Dobri Kitipov

        Issue Links

          Activity

          Dobri Kitipov created issue -
          Hide
          Dobri Kitipov added a comment -

          Attach the superinterface.

          Show
          Dobri Kitipov added a comment - Attach the superinterface.
          Dobri Kitipov made changes -
          Field Original Value New Value
          Attachment SOAPFaultClassifier.java [ 12399541 ]
          Hide
          Dobri Kitipov added a comment -

          Attach the SOAPFaultCode patch.

          Show
          Dobri Kitipov added a comment - Attach the SOAPFaultCode patch.
          Dobri Kitipov made changes -
          Attachment SOAPFaultCode_patch.patch [ 12399542 ]
          Hide
          Dobri Kitipov added a comment -

          Attach the SOAPFaultSubCode patch.

          Show
          Dobri Kitipov added a comment - Attach the SOAPFaultSubCode patch.
          Dobri Kitipov made changes -
          Attachment SOAPFaultSubCode_patch.patch [ 12399543 ]
          Andreas Veithen made changes -
          Assignee Andreas Veithen [ veithen ]
          Fix Version/s Axiom 1.2.9 [ 12313561 ]
          Andreas Veithen made changes -
          Link This issue blocks AXIS2-4216 [ AXIS2-4216 ]
          Hide
          Andreas Veithen added a comment -

          Patch applied; see r944209.

          Show
          Andreas Veithen added a comment - Patch applied; see r944209.
          Andreas Veithen made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Andreas Veithen made changes -
          Project WS-Commons [ 12310250 ] Axiom [ 12311190 ]
          Key WSCOMMONS-437 AXIOM-300
          Component/s AXIOM [ 12310703 ]
          Fix Version/s Axiom 1.2.9 [ 12313561 ]
          Jeff Turner made changes -
          Fix Version/s Axiom 1.2.9 [ 12315532 ]
          Andreas Veithen made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Andreas Veithen
              Reporter:
              Dobri Kitipov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development