Apache AWF
  1. Apache AWF
  2. AWF-77

AsynchronousHttpClient.fetch(..) "leaks" IllegalArgumentException if port is out of range

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Labels:
      None

      Description

      Exception in thread "I/O-LOOP" java.lang.IllegalArgumentException: port out of range:80811
      Its because we create an java.net.InetSocketAddress..

      doc for ISA:
      IllegalArgumentException - if the port parameter is outside the range of valid port values, or if the hostname parameter is null.

        Activity

        Anonymous created issue -
        Roger Schildmeijer made changes -
        Field Original Value New Value
        Priority Trivial [ 5 ]
        Roger Schildmeijer made changes -
        Fix Version/s 0.4.0 [ 12317348 ]
        Johnathan Meehan made changes -
        Assignee Johnathan Meehan [ jmeehan ]
        Johnathan Meehan made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Johnathan Meehan added a comment -

        Committed: http://svn.apache.org/viewvc?rev=1154415&view=rev

        Defaults to 80 when outside of range, extending upon functionality already in place. Logs warning; should be dealt with rather than silently handled.

        Show
        Johnathan Meehan added a comment - Committed: http://svn.apache.org/viewvc?rev=1154415&view=rev Defaults to 80 when outside of range, extending upon functionality already in place. Logs warning; should be dealt with rather than silently handled.
        Hide
        Johnathan Meehan added a comment -

        Ready for review.

        Show
        Johnathan Meehan added a comment - Ready for review.
        Johnathan Meehan made changes -
        Resolution Fixed [ 1 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        Hide
        Johnathan Meehan added a comment -

        Looking at this again today, wondering if it should not be reverted.

        Show
        Johnathan Meehan added a comment - Looking at this again today, wondering if it should not be reverted.
        Hide
        Roger Schildmeijer added a comment -

        Maybe its ok (and the preferred way) to expose the third party dev. to the IllegalArgumentException?

        Show
        Roger Schildmeijer added a comment - Maybe its ok (and the preferred way) to expose the third party dev. to the IllegalArgumentException?
        Hide
        Johnathan Meehan added a comment -

        I think so; the behaviour is now potentially quite confusing as we might retrieve something entirely unexpected. If the caller is making this kind of mistake, we should probably just let him know. Perhaps it's enough to document the thrown exception for the affected methods?

        Show
        Johnathan Meehan added a comment - I think so; the behaviour is now potentially quite confusing as we might retrieve something entirely unexpected. If the caller is making this kind of mistake, we should probably just let him know. Perhaps it's enough to document the thrown exception for the affected methods?
        Hide
        Roger Schildmeijer added a comment -

        +1 for that behaviour

        Show
        Roger Schildmeijer added a comment - +1 for that behaviour
        Johnathan Meehan made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Johnathan Meehan made changes -
        Status Reopened [ 4 ] In Progress [ 3 ]
        Hide
        Johnathan Meehan added a comment -

        Committed: http://svn.apache.org/viewvc?rev=1158408&view=rev

        Reverted revision 1154415 for the affected types, and added documentation to the public methods instead. Please review.

        Show
        Johnathan Meehan added a comment - Committed: http://svn.apache.org/viewvc?rev=1158408&view=rev Reverted revision 1154415 for the affected types, and added documentation to the public methods instead. Please review.
        Johnathan Meehan made changes -
        Resolution Fixed [ 1 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        Hide
        Roger Schildmeijer added a comment -

        +1

        Show
        Roger Schildmeijer added a comment - +1
        Roger Schildmeijer made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Tony Stevenson made changes -
        Project Deft [ 12311521 ] Apache AWF [ 12313220 ]
        Key DEFT-131 AWF-77
        Reporter Niklas Gustavsson [ niklas ]
        Fix Version/s 0.4.0 [ 12317348 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        25d 15h 5m 1 Johnathan Meehan 05/Aug/11 23:30
        Resolved Resolved Reopened Reopened
        7d 21h 6m 1 Johnathan Meehan 13/Aug/11 20:51
        Reopened Reopened In Progress In Progress
        10s 1 Johnathan Meehan 13/Aug/11 20:51
        In Progress In Progress Resolved Resolved
        2d 21h 43m 2 Johnathan Meehan 16/Aug/11 18:21
        Resolved Resolved Closed Closed
        8m 41s 1 Roger Schildmeijer 16/Aug/11 18:29

          People

          • Assignee:
            Johnathan Meehan
            Reporter:
            Niklas Gustavsson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development