> Understood thanks, but I still have questions. Bear with me.
No problem Johnathan, I'll try to explain better
>I'm still curious about passing null for "params". Why not just remove it from the signatrue and set the local to an
>empty Map (or null, I suppose)?
>If this constructor is specific to creating a HttpRequest suitable for partials, what about documenting that fact and
>then removing the QUERY_STRING_PATTERN split? If I understand, that will always be a split on "<>", so you
>could just set "requestPath" directly.
You are right, but I don't have created this constructor only for Partials, because are also other classes in Deft that can switch to it (MalFormedHttpRequest for example) and save superfluous steps
However in general, the truth is that when I develop my code, I prefer to create 'dummy' constructor (whit all, or most, settable properties) and, when needed, more constructors that, with less parameters, try to compute the others. Excuse me, if my patch contains some superfluous code
Feel free to give me advice, and with pleasure I'll change the patch
- this is not the right place, but I think that instead of private final fields, for optional properties, can be better to find another solution (like deleting setters), because in this way subclassing HttpRequest is more difficult