Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Labels:
      None

      Description

      Just a thought.
      Proposal:

      @Path("/")
      class SynchronousRequestHandler extends RequestHandler {

      @Override
      public void get(HttpRequest request, HttpResponse response)

      { response.write("hello world!"); }

      }

      public static void main(String[] args)

      { List <RequestHandler> handlers = new LinkedList<RequestHandler>(); handlers.add(new SynchronousRequestHandler()); HttpServer server = new HttpServer(new Application(handlers)); server.listen(8080); IOLoop.INSTANCE.start(); }
      1. deft-100.patch
        183 kB
        Johnathan Meehan

        Activity

        Hide
        jmeehan Johnathan Meehan added a comment -

        I like this idea, but perhaps we should wrap the JIRA in something broader? Rather than just implement it, make it part of a general sub-project to manage configuration of the server nicely.

        Show
        jmeehan Johnathan Meehan added a comment - I like this idea, but perhaps we should wrap the JIRA in something broader? Rather than just implement it, make it part of a general sub-project to manage configuration of the server nicely.
        Hide
        rschildmeijer Roger Schildmeijer added a comment -

        sub-project could be an idea. Not sure I like the idea to have both versions (old one, currently in use + the one proposed in this issue) in the main deft code. (adds complexity to the end user)

        Show
        rschildmeijer Roger Schildmeijer added a comment - sub-project could be an idea. Not sure I like the idea to have both versions (old one, currently in use + the one proposed in this issue) in the main deft code. (adds complexity to the end user)
        Hide
        jmeehan Johnathan Meehan added a comment -

        Attachment is incomplete and broken, but need to get other work committed before this can be properly merged. So, here for safekeeping and not review.

        Certainly agree with removing the old way of creating handlers, and annotation is implemented as proposed.

        Show
        jmeehan Johnathan Meehan added a comment - Attachment is incomplete and broken, but need to get other work committed before this can be properly merged. So, here for safekeeping and not review. Certainly agree with removing the old way of creating handlers, and annotation is implemented as proposed.
        Hide
        jmeehan Johnathan Meehan added a comment - - edited

        Initial implementation, for review.
        Includes changes for DEFT-175, as they are intrinsic. Assuming this is satisfactory, I think a next improvement might be to perhaps allow multiple path entries for a single handler.

        Show
        jmeehan Johnathan Meehan added a comment - - edited Initial implementation, for review. Includes changes for DEFT-175 , as they are intrinsic. Assuming this is satisfactory, I think a next improvement might be to perhaps allow multiple path entries for a single handler.
        Hide
        rschildmeijer Roger Schildmeijer added a comment -

        Believe it not but had some minor issues applying the patch.

        But I still managed to review the patch (DEFT-100 and DEFT-175).
        It looks good and I'm +1...so feel free to commit (great job)

        Show
        rschildmeijer Roger Schildmeijer added a comment - Believe it not but had some minor issues applying the patch. But I still managed to review the patch ( DEFT-100 and DEFT-175 ). It looks good and I'm +1...so feel free to commit (great job)
        Hide
        jmeehan Johnathan Meehan added a comment -
        Show
        jmeehan Johnathan Meehan added a comment - Committed under revision 1153226. http://svn.apache.org/viewvc?view=revision&revision=1153226
        Hide
        rschildmeijer Roger Schildmeijer added a comment -

        We forgot to update CHANGES.txt with this change

        Show
        rschildmeijer Roger Schildmeijer added a comment - We forgot to update CHANGES.txt with this change
        Hide
        jmeehan Johnathan Meehan added a comment -

        Darn. I put it in NEWS.txt, but there's always something. Snuck it in whilst nobody was looking:
        http://svn.apache.org/viewvc?view=revision&revision=1153238

        Show
        jmeehan Johnathan Meehan added a comment - Darn. I put it in NEWS.txt, but there's always something. Snuck it in whilst nobody was looking: http://svn.apache.org/viewvc?view=revision&revision=1153238

          People

          • Assignee:
            jmeehan Johnathan Meehan
            Reporter:
            niklas Niklas Gustavsson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development