Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      Ensure that headers required to support date format values do so. For example, "If-Modified-Since" should handle this.

      1. deft96.patch
        7 kB
        Johnathan Meehan

        Activity

        Anonymous created issue -
        Show
        Ulrich Stärk added a comment - Proposal: https://github.com/johnathanmeehan/deft/commit/e972f6a5270713b16c5cf178ab37f9895549fa09
        Roger Schildmeijer made changes -
        Field Original Value New Value
        Issue Type Bug [ 1 ] New Feature [ 2 ]
        Priority Major [ 3 ]
        Hide
        Johnathan Meehan added a comment -

        This is a small fix, and was never pulled from the branch. Will handle as an initial commit.

        Show
        Johnathan Meehan added a comment - This is a small fix, and was never pulled from the branch. Will handle as an initial commit.
        Johnathan Meehan made changes -
        Assignee Johnathan Meehan [ jmeehan ]
        Johnathan Meehan made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Johnathan Meehan added a comment - - edited

        Restoration of original patch; may be updated before commit when code moves to trunk. Ran the original checks again with the following output:

        $ curl --head --header "If-Modified-Since: 1298224366000" -i http://localhost:8080/static/gillian.jpg
        HTTP/1.1 200 OK
        Date: Sat, 23 Jul 2011 19:42:59 GMT
        Content-Length: 0
        Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT
        Content-Type: image/jpeg
        Connection: Keep-Alive
        Server: Deft/0.4.0-SNAPSHOT
        Cache-Control: public

        $ curl --head --header "If-Modified-Since: 12982243660" -i http://localhost:8080/static/gillian.jpg
        HTTP/1.1 200 OK
        Date: Sat, 23 Jul 2011 19:43:45 GMT
        Content-Length: 0
        Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT
        Content-Type: image/jpeg
        Connection: Keep-Alive
        Server: Deft/0.4.0-SNAPSHOT
        Cache-Control: public

        $ curl --head --header "If-Modified-Since: Fri, 20 Feb 2065 15:36:27 GMT" -i http://localhost:8080/static/gillian.jpg
        HTTP/1.1 304 Not Modified
        Date: Sat, 23 Jul 2011 19:44:00 GMT
        Content-Length: 0
        Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT
        Content-Type: image/jpeg
        Connection: Keep-Alive
        Server: Deft/0.4.0-SNAPSHOT
        Cache-Control: public

        $ curl --head --header "If-Modified-Since: Sun, 20 Feb 2011 15:36:27 GMT" -i http://localhost:8080/static/gillian.jpg
        HTTP/1.1 200 OK
        Date: Sat, 23 Jul 2011 19:44:16 GMT
        Content-Length: 0
        Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT
        Content-Type: image/jpeg
        Connection: Keep-Alive
        Server: Deft/0.4.0-SNAPSHOT
        Cache-Control: public

        Show
        Johnathan Meehan added a comment - - edited Restoration of original patch; may be updated before commit when code moves to trunk. Ran the original checks again with the following output: $ curl --head --header "If-Modified-Since: 1298224366000" -i http://localhost:8080/static/gillian.jpg HTTP/1.1 200 OK Date: Sat, 23 Jul 2011 19:42:59 GMT Content-Length: 0 Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT Content-Type: image/jpeg Connection: Keep-Alive Server: Deft/0.4.0-SNAPSHOT Cache-Control: public $ curl --head --header "If-Modified-Since: 12982243660" -i http://localhost:8080/static/gillian.jpg HTTP/1.1 200 OK Date: Sat, 23 Jul 2011 19:43:45 GMT Content-Length: 0 Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT Content-Type: image/jpeg Connection: Keep-Alive Server: Deft/0.4.0-SNAPSHOT Cache-Control: public $ curl --head --header "If-Modified-Since: Fri, 20 Feb 2065 15:36:27 GMT" -i http://localhost:8080/static/gillian.jpg HTTP/1.1 304 Not Modified Date: Sat, 23 Jul 2011 19:44:00 GMT Content-Length: 0 Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT Content-Type: image/jpeg Connection: Keep-Alive Server: Deft/0.4.0-SNAPSHOT Cache-Control: public $ curl --head --header "If-Modified-Since: Sun, 20 Feb 2011 15:36:27 GMT" -i http://localhost:8080/static/gillian.jpg HTTP/1.1 200 OK Date: Sat, 23 Jul 2011 19:44:16 GMT Content-Length: 0 Last-Modified: Tue, 22 Feb 2011 21:26:28 GMT Content-Type: image/jpeg Connection: Keep-Alive Server: Deft/0.4.0-SNAPSHOT Cache-Control: public
        Johnathan Meehan made changes -
        Attachment deft96.patch [ 12487609 ]
        Hide
        Roger Schildmeijer added a comment -

        +1

        Show
        Roger Schildmeijer added a comment - +1
        Hide
        Emmanuel Lecharny added a comment -

        patch applied

        Show
        Emmanuel Lecharny added a comment - patch applied
        Hide
        Roger Schildmeijer added a comment -

        Thanks Emmanuel

        Show
        Roger Schildmeijer added a comment - Thanks Emmanuel
        Roger Schildmeijer made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Roger Schildmeijer made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Johnathan Meehan made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Johnathan Meehan made changes -
        Fix Version/s 0.4.0 [ 12317348 ]
        Johnathan Meehan made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Johnathan Meehan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Tony Stevenson made changes -
        Project Deft [ 12311521 ] Apache AWF [ 12313220 ]
        Key DEFT-96 AWF-149
        Reporter Niklas Gustavsson [ niklas ]
        Issue Type New Feature [ 2 ] Bug [ 1 ]
        Fix Version/s 0.4.0 [ 12317348 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        4d 13h 15m 1 Johnathan Meehan 15/Jul/11 22:40
        In Progress In Progress Resolved Resolved
        11d 9h 55m 1 Roger Schildmeijer 27/Jul/11 08:36
        Closed Closed Reopened Reopened
        5d 14h 17m 1 Johnathan Meehan 01/Aug/11 22:53
        Reopened Reopened Resolved Resolved
        21s 1 Johnathan Meehan 01/Aug/11 22:54
        Resolved Resolved Closed Closed
        13s 2 Johnathan Meehan 01/Aug/11 22:54

          People

          • Assignee:
            Johnathan Meehan
            Reporter:
            Niklas Gustavsson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development