Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Labels:
      None

      Activity

      Hide
      Roger Schildmeijer added a comment -

      Having problems applying the patch. Is the patch made from sandbox? (latest on sandbox/trunk)?
      It's not a big deal this time, because the code changes are small. But its probably a good idea to rebase the patch

      Show
      Roger Schildmeijer added a comment - Having problems applying the patch. Is the patch made from sandbox? (latest on sandbox/trunk)? It's not a big deal this time, because the code changes are small. But its probably a good idea to rebase the patch
      Hide
      Michele Zuccalà added a comment -

      I'm too busy at this moment, then I can't produce some useful patch for now
      But some times ago I've prepared the following simple fix for Etag's handling in deft:

      I've added two methods in HttpResponse class

      • setEtag(String) that override default etag generated string, with custom one
      • generateEtag(boolean) that enable/disable the automatic etag generation (default disable)

      in this way, i think that the final developer could have better control of etags

      Show
      Michele Zuccalà added a comment - I'm too busy at this moment, then I can't produce some useful patch for now But some times ago I've prepared the following simple fix for Etag's handling in deft: I've added two methods in HttpResponse class setEtag(String) that override default etag generated string, with custom one generateEtag(boolean) that enable/disable the automatic etag generation (default disable) in this way, i think that the final developer could have better control of etags
      Hide
      Michele Zuccalà added a comment -

      This is my proposal for this issue.
      It 'also my first patch created from the svn repository using git, please report me if you have any difficulty in using it

      thanks

      Show
      Michele Zuccalà added a comment - This is my proposal for this issue. It 'also my first patch created from the svn repository using git, please report me if you have any difficulty in using it thanks
      Hide
      Adam Lofts added a comment -

      Well its always nice to have options

      My patch was against the github tree so I guess thats why it didn't apply. It would take me a while to learn git-svn so it is some effort for me to rebase it for the small change (though I can understand the motivations for becoming an Apache project).

      Personally I prefer the implicit API of 'overriding the headers' that my patch uses but either approach is cool for usage in my app.

      Show
      Adam Lofts added a comment - Well its always nice to have options My patch was against the github tree so I guess thats why it didn't apply. It would take me a while to learn git-svn so it is some effort for me to rebase it for the small change (though I can understand the motivations for becoming an Apache project). Personally I prefer the implicit API of 'overriding the headers' that my patch uses but either approach is cool for usage in my app.

        People

        • Assignee:
          Unassigned
          Reporter:
          Adam Lofts
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:

            Development