[AVRO-999] NPE in Java, RecordBuilderBase.defaultValue

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.6.1
• Fix Version/s: 1.6.2
• Component/s: java

Environment

Java

• Assignee: Unassigned
• Reporter: Jay Rutten
• Created: 19/Jan/12 20:10
• Updated: 25/Sep/12 21:24
• Resolved: 23/Feb/12 22:14

Description

If you have a union with a default of null, the code in RecordBuilderBase.defaultValue will cause an NPE in ConcurrentHashMap, since it is trying to add a null to the map.

Sample union:

record Sample {
    union{null, string} value = null;
}

Code:

// If not cached, get the default Java value by encoding the default JSON
// value and then decoding it:
if (defaultValue == null) {
  ByteArrayOutputStream baos = new ByteArrayOutputStream();
  encoder = EncoderFactory.get().binaryEncoder(baos, encoder);
  ResolvingGrammarGenerator.encode(encoder, field.schema(), defaultJsonValue);
  encoder.flush();
  decoder = DecoderFactory.get().binaryDecoder(baos.toByteArray(), decoder);
  defaultValue = new GenericDatumReader(field.schema()).read(null, decoder);
  defaultSchemaValues.putIfAbsent(field.pos(), defaultValue); // <-- NPE from here
}