Avro
  1. Avro
  2. AVRO-990

ruby impl failed when the local_protocol not same with remote_protocol

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.6.1
    • Fix Version/s: None
    • Component/s: ruby
    • Labels:
      None

      Description

      For Requestor class,when local_protocol is not same with remote_protocol,Requestor makes REMOTE_HASHES[transport.remote_name] has value, and skips " self.remote_protocol = local_protocol" in the write_handshake_request method, making the next new Requestor object's @remote_protocol always nil.

      1. ipc.patch
        0.8 kB
        kafka0102

        Activity

        Hide
        kafka0102 added a comment -

        I got the possible patch.

        Show
        kafka0102 added a comment - I got the possible patch.
        Hide
        kafka0102 added a comment -

        for the impl,the golbal varible REMOTE_PROTOCOLS is never be used.It's weird...

        Show
        kafka0102 added a comment - for the impl,the golbal varible REMOTE_PROTOCOLS is never be used.It's weird...
        Hide
        Doug Cutting added a comment -

        Can someone familiar with Ruby please review this? Thanks!

        Show
        Doug Cutting added a comment - Can someone familiar with Ruby please review this? Thanks!
        Hide
        Doug Cutting added a comment -

        It would also be good to have a test case included in the patch, if possible.

        Show
        Doug Cutting added a comment - It would also be good to have a test case included in the patch, if possible.

          People

          • Assignee:
            Unassigned
            Reporter:
            kafka0102
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development