Avro
  1. Avro
  2. AVRO-952

C++/CMake build does not detect flex & bison correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.6.0
    • Fix Version/s: None
    • Component/s: c++
    • Labels:

      Description

      Configure should test for flex and bison. CMake has built in support for those, we should use that. I've verified that it existed at 2.6, which is the minimum CMake release that we currently require.

      1. AVRO-952.patch
        2 kB
        Nebojsa Sabovic

        Activity

        Hide
        Thiruvalluvan M. G. added a comment -

        The C++ port no longer uses Flex or Bison and hence this problem no longer exists.

        Thank you Nebojsa Sabovic for looking into this issue.

        Show
        Thiruvalluvan M. G. added a comment - The C++ port no longer uses Flex or Bison and hence this problem no longer exists. Thank you Nebojsa Sabovic for looking into this issue.
        Hide
        Thiruvalluvan M. G. added a comment -

        This is a valid patch. However, I'm almost done with porting Avro C++ to Miscrosoft Windows. CMake + Windows + Flex/Bison appear to be a problem combination. Moreover, the Schema parser based on Flex/Bison is not complete and produces no good error messages. I've implemented a new parser on top of Json parser we already have in Avro C++. We can then implement full compliance to Avro standard including namespaces, docs etc.

        I'll file 2 Jiras one for getting rid of dependence on flex/bison and BoostRegex and another for porting to Microsoft Windows. With those patches we don't have to fix the Flex/Bison find problems.

        Show
        Thiruvalluvan M. G. added a comment - This is a valid patch. However, I'm almost done with porting Avro C++ to Miscrosoft Windows. CMake + Windows + Flex/Bison appear to be a problem combination. Moreover, the Schema parser based on Flex/Bison is not complete and produces no good error messages. I've implemented a new parser on top of Json parser we already have in Avro C++. We can then implement full compliance to Avro standard including namespaces, docs etc. I'll file 2 Jiras one for getting rid of dependence on flex/bison and BoostRegex and another for porting to Microsoft Windows. With those patches we don't have to fix the Flex/Bison find problems.
        Hide
        Nebojsa Sabovic added a comment -

        Fix

        Show
        Nebojsa Sabovic added a comment - Fix

          People

          • Assignee:
            Unassigned
            Reporter:
            Nebojsa Sabovic
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development