Avro
  1. Avro
  2. AVRO-949

NettyTransiever doesn't call RPCPlugin.clientReceiveResponse on the same thread as clientSendRequest

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.5.4, 1.6.0
    • Fix Version/s: None
    • Component/s: java
    • Labels:
      None

      Description

      RPCPlugin.clientReceiveResponse() is called in the Netty IO thread when using a NettyTransceiver. This is quite different than how HTTPTransceiver does it.

      Users can use RPCPlugin to do things like tracing and timing. It's bizarre that clientSendRequest() happens in the caller's thread, but clientReceiveResponse() happens in a different one, because thread locals are one of the easiest way to pass information between these. There's no easy other way, since RPCContext, which is passed along, has no way to associate arbitrary data with itself.

        Activity

        Philip Zeyliger created issue -
        Hide
        Doug Cutting added a comment -

        Maybe we should add 'Map<Object,Object> getProps()' to RpcPlugin?

        Show
        Doug Cutting added a comment - Maybe we should add 'Map<Object,Object> getProps()' to RpcPlugin?
        Hide
        Doug Cutting added a comment -

        RPCContext, I mean.

        Show
        Doug Cutting added a comment - RPCContext, I mean.
        Doug Cutting made changes -
        Field Original Value New Value
        Component/s java [ 12312780 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development