Avro
  1. Avro
  2. AVRO-917

Avrogencpp does not insert avro prefix for avro headers in the generated files.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: c++
    • Labels:
      None

      Description

      The generated files have include directives like #include "Specific.hh". This forces the users to add things like -I/usr/local/avro to their build scripts.If, instead, the generated code had #include "avro/Specific.hh" the users can use something like -I/usr/local (or omit it altogether because many systems may already have /usr/local in their include paths).

      1. AVRO-917.patch
        3 kB
        Thiruvalluvan M. G.

        Activity

        Thiruvalluvan M. G. created issue -
        Hide
        Thiruvalluvan M. G. added a comment -

        avrogencpp now takes an additional argument - p or -include-prefix which is the prefix for header files. If omitted, avro/ becomes the prefix. If set to {} no prefix is added.

        Show
        Thiruvalluvan M. G. added a comment - avrogencpp now takes an additional argument - p or - include-prefix which is the prefix for header files. If omitted, avro/ becomes the prefix. If set to { } no prefix is added.
        Thiruvalluvan M. G. made changes -
        Field Original Value New Value
        Attachment AVRO-917.patch [ 12498321 ]
        Thiruvalluvan M. G. made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Thiruvalluvan M. G. added a comment -

        Jira's formatting took away a -. It should read if set to -, no prefix is added.

        Show
        Thiruvalluvan M. G. added a comment - Jira's formatting took away a -. It should read if set to -, no prefix is added.
        Hide
        Thiruvalluvan M. G. added a comment -

        If there are no objections, I'll commit this tomorrow.

        Show
        Thiruvalluvan M. G. added a comment - If there are no objections, I'll commit this tomorrow.
        Hide
        Thiruvalluvan M. G. added a comment -

        Committed revision 1182341.

        Show
        Thiruvalluvan M. G. added a comment - Committed revision 1182341.
        Thiruvalluvan M. G. made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3h 59m 1 Thiruvalluvan M. G. 08/Oct/11 18:15
        Patch Available Patch Available Resolved Resolved
        3d 19h 43m 1 Thiruvalluvan M. G. 12/Oct/11 13:59
        Resolved Resolved Closed Closed
        20d 5h 36m 1 Doug Cutting 01/Nov/11 18:36

          People

          • Assignee:
            Thiruvalluvan M. G.
            Reporter:
            Thiruvalluvan M. G.
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development