Avro
  1. Avro
  2. AVRO-795

C++ Datafile reader makes it hard to build adaptive clients

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.5.1
    • Component/s: c++
    • Labels:
      None

      Description

      The current design of data file requires the C++ type for the data to be read is passed as a template argument to the DataFileReader class.

      This makes it hard for the client who want to examine the schema within the data file before deciding the C++ data type. The forthcoming patch addresses this problem.

      1. AVRO-795.patch
        12 kB
        Thiruvalluvan M. G.

        Activity

        Hide
        Thiruvalluvan M. G. added a comment -

        Committed revision 1089131. Thanks Doug for reviewing it.

        Show
        Thiruvalluvan M. G. added a comment - Committed revision 1089131. Thanks Doug for reviewing it.
        Hide
        Doug Cutting added a comment -

        Looks reasonable and tests pass for me on Ubuntu 10.10. +1

        Show
        Doug Cutting added a comment - Looks reasonable and tests pass for me on Ubuntu 10.10. +1
        Hide
        Thiruvalluvan M. G. added a comment -

        This patch addresses the problem by replacing inheritance with composition.

        Show
        Thiruvalluvan M. G. added a comment - This patch addresses the problem by replacing inheritance with composition.

          People

          • Assignee:
            Thiruvalluvan M. G.
            Reporter:
            Thiruvalluvan M. G.
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development