Avro
  1. Avro
  2. AVRO-754

NettyTransceiver: allow to provide custom ChannelFactory

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.5.0
    • Component/s: java
    • Labels:
      None

      Description

      The threads created by NettyTransceiver are non-daemon threads. The effect is that in client apps you need to properly call NettyTransceiver.close() or it will hang when done.

      In order to be able to control the kinds of threads (and thread pools) used, the attached patch allows to pass the ChannelFactory via the constructor. Alternatively, I'd also be happy with the ability to pass the ThreadFactory or the ExecutorService, or by making daemon threads the default.

        Activity

        Bruno Dumon created issue -
        Bruno Dumon made changes -
        Field Original Value New Value
        Attachment nettytransceiver-custom-channelfactory-patch.txt [ 12469922 ]
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Bruno!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Bruno!
        Doug Cutting made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Bruno Dumon [ bruno ]
        Fix Version/s 1.5.0 [ 12315282 ]
        Resolution Fixed [ 1 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Bruno Dumon
            Reporter:
            Bruno Dumon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development