Avro
  1. Avro
  2. AVRO-733

Avro Java r1059016 does not build due to Checkstyle faulure

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.5.0
    • Component/s: java
    • Labels:
      None
    • Environment:

      Win7, JDK6, maven 3.0.2

      Description

      Trying to build avro-java from svn trunk fails in checkstyle:

      "Unused import - org.apache.avro.UnresolvedUnionException" in
      ipc\src\main\java\org\apache\avro\specific\SpecificResponder.java

      I had to run with -Dcheckstyle.skip=true to get anywhere. Maybe consider running checkstyle only on demand or on the build server (set "skip" property from default false to true in the pom and pass skip=false to enable when required).

      1. AVRO-733.2.patch
        0.4 kB
        Scott Carey
      2. AVRO-733.patch
        0.6 kB
        Scott Carey

        Activity

        Hide
        Scott Carey added a comment -

        checkstyle changed to 'test' phase from 'verify' phase.

        Show
        Scott Carey added a comment - checkstyle changed to 'test' phase from 'verify' phase.
        Hide
        Scott Carey added a comment -

        tiny patch to change checkstyle to be bound to the 'test' phase instead of the 'verify' phase.

        Show
        Scott Carey added a comment - tiny patch to change checkstyle to be bound to the 'test' phase instead of the 'verify' phase.
        Hide
        Holger Hoffstätte added a comment -

        Agreed, binding to test phase is good. My primary stumbling block was that I had to run install before eclipse (no m2eclipse plugin here) and that failed, so I got nowhere until I found the checkstyle.skip flag..

        Show
        Holger Hoffstätte added a comment - Agreed, binding to test phase is good. My primary stumbling block was that I had to run install before eclipse (no m2eclipse plugin here) and that failed, so I got nowhere until I found the checkstyle.skip flag..
        Hide
        Scott Carey added a comment -

        I'll move checkstyle to the test phase and commit that on this JIRA later today unless there are objections.

        Show
        Scott Carey added a comment - I'll move checkstyle to the test phase and commit that on this JIRA later today unless there are objections.
        Hide
        Doug Cutting added a comment -

        +1 for adding checkstyle to the 'test' phase, to better prevent this sort of thing in the future.

        Show
        Doug Cutting added a comment - +1 for adding checkstyle to the 'test' phase, to better prevent this sort of thing in the future.
        Hide
        Scott Carey added a comment -

        I have committed this.

        Show
        Scott Carey added a comment - I have committed this.
        Hide
        Scott Carey added a comment -

        Note that 'mvn install' will run checkstyle. 'mvn test' will not.

        Documentation on the new build is not complete yet (AVRO-714) – proper testing before a checkin requires 'mvn install' rather than only 'mvn test'. Alternatively we could attach checkstyle to the 'test' phase.

        Show
        Scott Carey added a comment - Note that 'mvn install' will run checkstyle. 'mvn test' will not. Documentation on the new build is not complete yet ( AVRO-714 ) – proper testing before a checkin requires 'mvn install' rather than only 'mvn test'. Alternatively we could attach checkstyle to the 'test' phase.
        Hide
        Scott Carey added a comment -

        Unless there are objections, I'll commit this later today.

        Show
        Scott Carey added a comment - Unless there are objections, I'll commit this later today.
        Hide
        Scott Carey added a comment -

        I noticed this last night as well and was planning on addressing it with some other things. Very simple patch to follow.

        Show
        Scott Carey added a comment - I noticed this last night as well and was planning on addressing it with some other things. Very simple patch to follow.

          People

          • Assignee:
            Scott Carey
            Reporter:
            Holger Hoffstätte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development