Avro
  1. Avro
  2. AVRO-715

New Java build: refactor tests to use shared method for identifying temp file location

    Details

    • Type: Task Task
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: java
    • Labels:
      None

      Description

      Many tests individually write temp files based on relative paths, '/tmp', or reading from a system property. These need to be refactored into one utility for handling the location of temp files for unit tests.

        Activity

        Hide
        Scott Carey added a comment -

        minor, does not block 1.5.0

        Show
        Scott Carey added a comment - minor, does not block 1.5.0
        Hide
        Doug Cutting added a comment -

        I agree, target/test would be better. We could try to get Maven to create that directory or we could change the tests to create it.

        Show
        Doug Cutting added a comment - I agree, target/test would be better. We could try to get Maven to create that directory or we could change the tests to create it.
        Hide
        Scott Carey added a comment -

        Also, if the temp directory is just target/ it is a little dangerous – we might collide with other build output unexpectedly. If we change it to target/test it currently breaks because we don't create the directory when it doesn't exist, and it won't after 'clean'.

        Show
        Scott Carey added a comment - Also, if the temp directory is just target/ it is a little dangerous – we might collide with other build output unexpectedly. If we change it to target/test it currently breaks because we don't create the directory when it doesn't exist, and it won't after 'clean'.
        Hide
        Doug Cutting added a comment -

        Note taht with http://svn.apache.org/viewvc?view=revision&revision=1050474 this is not critical for 1.5.0 but would still be an improvement.

        Show
        Doug Cutting added a comment - Note taht with http://svn.apache.org/viewvc?view=revision&revision=1050474 this is not critical for 1.5.0 but would still be an improvement.

          People

          • Assignee:
            Scott Carey
            Reporter:
            Scott Carey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development