Avro
  1. Avro
  2. AVRO-692

permit 1.2-format files to be read

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.0
    • Component/s: java
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It might be useful to have the ability to read 1.2 format data files.

      1. test.avro12
        3 kB
        Doug Cutting
      2. AVRO-692.patch
        12 kB
        Doug Cutting
      3. AVRO-692.patch
        8 kB
        Doug Cutting

        Activity

        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Doug Cutting made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Doug Cutting added a comment -

        I committed this.

        Show
        Doug Cutting added a comment - I committed this.
        Hide
        Scott Carey added a comment -

        +1 I did not review DataFileReader12.java in detail. I looked at the rest of the patch closely and it looks good. Related tests pass.

        Show
        Scott Carey added a comment - +1 I did not review DataFileReader12.java in detail. I looked at the rest of the patch closely and it looks good. Related tests pass.
        Hide
        Doug Cutting added a comment -

        Unless there are objections, I'll commit this soon.

        Show
        Doug Cutting added a comment - Unless there are objections, I'll commit this soon.
        Doug Cutting made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Doug Cutting made changes -
        Attachment test.avro12 [ 12460319 ]
        Hide
        Doug Cutting added a comment -

        A 1.2 format file, for tests.

        Show
        Doug Cutting added a comment - A 1.2 format file, for tests.
        Doug Cutting made changes -
        Attachment AVRO-692.patch [ 12460318 ]
        Hide
        Doug Cutting added a comment -

        Here's a new version of the patch that adds a static factory method, DataFileReader.openReader(), which looks at the file's version number and uses either the current implementation or the 1.2 implementation. The "tojson" tool and the MapReduce task are also updated to use this factory.

        Show
        Doug Cutting added a comment - Here's a new version of the patch that adds a static factory method, DataFileReader.openReader(), which looks at the file's version number and uses either the current implementation or the 1.2 implementation. The "tojson" tool and the MapReduce task are also updated to use this factory.
        Doug Cutting made changes -
        Field Original Value New Value
        Attachment AVRO-692.patch [ 12458847 ]
        Hide
        Doug Cutting added a comment -

        Here's the 1.2 file reader updated slightly so that it compiles in the current trunk.

        This still needs tests. Perhaps we should add a small sample data file into subversion that we can read in a test?

        Show
        Doug Cutting added a comment - Here's the 1.2 file reader updated slightly so that it compiles in the current trunk. This still needs tests. Perhaps we should add a small sample data file into subversion that we can read in a test?
        Doug Cutting created issue -

          People

          • Assignee:
            Doug Cutting
            Reporter:
            Doug Cutting
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development