Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.1
    • Component/s: java
    • Labels:
      None
    1. AVRO-636.patch.v4
      15 kB
      Patrick Wendell
    2. AVRO-636.patch.v3
      20 kB
      Patrick Wendell
    3. AVRO-636.patch.v2
      12 kB
      Patrick Wendell
    4. AVRO-636.patch.v1
      12 kB
      Patrick Wendell

      Activity

      Patrick Wendell created issue -
      Hide
      Patrick Wendell added a comment -

      This patch adds singleton access to the TracePlugin, Includes several unit tests.

      Show
      Patrick Wendell added a comment - This patch adds singleton access to the TracePlugin, Includes several unit tests.
      Patrick Wendell made changes -
      Field Original Value New Value
      Attachment AVRO-636.patch.v1 [ 12453191 ]
      Hide
      Philip Zeyliger added a comment -

      You should probably make the set and get methods synchronized here. Otherwise, looks good.

      Show
      Philip Zeyliger added a comment - You should probably make the set and get methods synchronized here. Otherwise, looks good.
      Hide
      Patrick Wendell added a comment -

      This adds synchronized to the two singleton related methods in TracePlugin.

      Show
      Patrick Wendell added a comment - This adds synchronized to the two singleton related methods in TracePlugin.
      Patrick Wendell made changes -
      Attachment AVRO-636.patch.v2 [ 12453253 ]
      Hide
      Philip Zeyliger added a comment -

      Patrick,

      After applying this patch, I'm seeing a test error:

              FAILED
      expected:<1> but was:<0>
      junit.framework.AssertionFailedError: expected:<1> but was:<0>
              at org.apache.avro.ipc.trace.TestBasicTracing.testRecursingTrace(TestBasicTracing.java:280)
      

      Could you confirm that this passes the tests?

      Thanks!

      Show
      Philip Zeyliger added a comment - Patrick, After applying this patch, I'm seeing a test error: FAILED expected:<1> but was:<0> junit.framework.AssertionFailedError: expected:<1> but was:<0> at org.apache.avro.ipc.trace.TestBasicTracing.testRecursingTrace(TestBasicTracing.java:280) Could you confirm that this passes the tests? Thanks!
      Hide
      Patrick Wendell added a comment -

      Fixing small bug in previous version that caused tests to fail

      Show
      Patrick Wendell added a comment - Fixing small bug in previous version that caused tests to fail
      Patrick Wendell made changes -
      Attachment AVRO-636.patch.v3 [ 12453306 ]
      Hide
      Patrick Wendell added a comment -

      accidentally included some extra code there... will upload new patch momentarily.

      Show
      Patrick Wendell added a comment - accidentally included some extra code there... will upload new patch momentarily.
      Hide
      Patrick Wendell added a comment -

      Here is a working patch sans extra code.

      Show
      Patrick Wendell added a comment - Here is a working patch sans extra code.
      Patrick Wendell made changes -
      Attachment AVRO-636.patch.v4 [ 12453311 ]
      Hide
      Philip Zeyliger added a comment -

      Just comitted this; thanks, Patrick.

      Show
      Philip Zeyliger added a comment - Just comitted this; thanks, Patrick.
      Philip Zeyliger made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Fixed [ 1 ]
      Doug Cutting made changes -
      Fix Version/s 1.4.1 [ 12315281 ]
      Doug Cutting made changes -
      Component/s java [ 12312780 ]
      Doug Cutting made changes -
      Status Resolved [ 5 ] Closed [ 6 ]

        People

        • Assignee:
          Patrick Wendell
          Reporter:
          Patrick Wendell
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development