Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-440

config.h output not correctly used

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.3.0
    • 1.3.1
    • c
    • None

    Description

      While config.h is generated, it is only included from within st.c to make some things work correctly within st.h.

      I would suggest changing things a little:

      • Put an include of config.h into src/avro_private.h
      • Include avro_private.h into all .c files.
      • Not sure if the values from config.h are needed in any of the tests or examples ... I would hope not though and that this is fully insulated from being visible within anything exposed by avro.h.

      Given some feedback, I can readily prepare a patch.

      Attachments

        1. avro_config_h_check.diff
          0.4 kB
          Bruce Mitchener

        Activity

          People

            brucem Bruce Mitchener
            brucem Bruce Mitchener
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: