Avro
  1. Avro
  2. AVRO-440

config.h output not correctly used

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.1
    • Component/s: c
    • Labels:
      None

      Description

      While config.h is generated, it is only included from within st.c to make some things work correctly within st.h.

      I would suggest changing things a little:

      • Put an include of config.h into src/avro_private.h
      • Include avro_private.h into all .c files.
      • Not sure if the values from config.h are needed in any of the tests or examples ... I would hope not though and that this is fully insulated from being visible within anything exposed by avro.h.

      Given some feedback, I can readily prepare a patch.

        Activity

        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Doug Cutting made changes -
        Fix Version/s 1.3.1 [ 12314788 ]
        Doug Cutting made changes -
        Assignee Bruce Mitchener [ brucem ]
        Matt Massie made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Bruce Mitchener made changes -
        Field Original Value New Value
        Attachment avro_config_h_check.diff [ 12438023 ]
        Bruce Mitchener created issue -

          People

          • Assignee:
            Bruce Mitchener
            Reporter:
            Bruce Mitchener
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development