Avro
  1. Avro
  2. AVRO-418

avro.h generates errors when included in C++ code

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.2
    • Component/s: c
    • Labels:
      None

      Description

      avro.h cannot be included in C++ code without errors

      1. avro_build_with_cpp.diff
        12 kB
        Bruce Mitchener
      2. AVRO-418.patch
        2 kB
        Matt Massie

        Activity

        Matt Massie created issue -
        Matt Massie made changes -
        Field Original Value New Value
        Assignee Matt Massie [ massie ]
        Hide
        Matt Massie added a comment -

        Patch provided by Eric Andersen. Thanks!

        Show
        Matt Massie added a comment - Patch provided by Eric Andersen. Thanks!
        Matt Massie made changes -
        Attachment avro.cpp.patch [ 12436074 ]
        Matt Massie made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Later [ 7 ]
        Hide
        Doug Cutting added a comment -

        Matt, what's the rationale for resolving this? Isn't it still a valid issue?

        Show
        Doug Cutting added a comment - Matt, what's the rationale for resolving this? Isn't it still a valid issue?
        Hide
        Matt Massie added a comment -

        Keeping this issue open since it's still an issue that needs to be addressed

        Show
        Matt Massie added a comment - Keeping this issue open since it's still an issue that needs to be addressed
        Matt Massie made changes -
        Resolution Later [ 7 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Doug Cutting made changes -
        Attachment avro.cpp.patch [ 12436074 ]
        Matt Massie made changes -
        Description Eric Anderson reported that avro.h cannot be included in C++ code. He provided a patch to workaround the problem. avro.h cannot be included in C++ code without errors
        Hide
        Matt Massie added a comment -

        This patch can be used as a workaround for this problem. We need someone better versed in C++ than myself to help design a correct solution to this problem.

        Show
        Matt Massie added a comment - This patch can be used as a workaround for this problem. We need someone better versed in C++ than myself to help design a correct solution to this problem.
        Matt Massie made changes -
        Attachment AVRO-418.patch [ 12438846 ]
        Bruce Mitchener made changes -
        Assignee Matt Massie [ massie ] Bruce Mitchener [ brucem ]
        Hide
        Bruce Mitchener added a comment -

        I think this is a better approach to addressing the problems ... it also includes a test program that will fail to compile if the other fixes aren't in place. I tested the test under the CMake build but NOT under autotools.

        Show
        Bruce Mitchener added a comment - I think this is a better approach to addressing the problems ... it also includes a test program that will fail to compile if the other fixes aren't in place. I tested the test under the CMake build but NOT under autotools.
        Bruce Mitchener made changes -
        Attachment avro_build_with_cpp.diff [ 12438858 ]
        Hide
        Matt Massie added a comment -

        Thanks for the patch, Bruce. Committed to trunk.

        Show
        Matt Massie added a comment - Thanks for the patch, Bruce. Committed to trunk.
        Matt Massie made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Bruce Mitchener made changes -
        Fix Version/s 1.3.1 [ 12314788 ]
        Bruce Mitchener made changes -
        Fix Version/s 1.3.2 [ 12314842 ]
        Fix Version/s 1.3.1 [ 12314788 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Bruce Mitchener
            Reporter:
            Matt Massie
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development