[AVRO-3721] [Java] Add cache to org.apache.avro.JsonProperties.getObjectProps

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.11.1
• Fix Version/s: 1.12.0
• Component/s: java
• Labels: pull-request-available

Language

Java

• Assignee: Unassigned
• Reporter: Moshe Elisha
• Created: 08/Mar/23 13:55
• Updated: 15/Mar/23 10:19
• Resolved: 13/Mar/23 15:06

Description

Currently every time you invoke JsonProperties.getObjectProps on same instance, the code loops over the props and creates a new LinkedHashMap and a new UnmodifiableMap.

 

In our use case, we store a Protocol (and the JsonProperties) and access the same instances multiple times.

 

Storing a simple cache "private Map<String, Object> objectProps;" inside JsonProperties will slightly improve performance and memory usage.

objectProps can be lazy initialized in JsonProperties.getObjectProps and reset when "JsonProperties.addProp(String, JsonNode)" is invoked.

 

Thanks.

Issue Links

• links to: GitHub Pull Request #2135