[AVRO-3642] GenericSingleObjectReader::read_value fails on non-exhaustive read

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0, 1.11.2
• Component/s: rust
• Labels: pull-request-available

Language

Rust

• Assignee: Martin Tzvetanov Grigorov
• Reporter: David Peklak
• Created: 17/Oct/22 19:59
• Updated: 24/Oct/22 07:33
• Resolved: 18/Oct/22 07:44

Description

There is a bug in the Rust implementation of GenericSingleObjectReader::read_value, which is exposed when a call to reader.read reads less than 10 bytes. This is a valid scenario, as according to the documentation of Read::read, "It is not an error if the returned value n is smaller than the buffer size, even when the reader is not at the end of the stream yet." This is also a real-life scenario: in my use-case, I am chaining three implementations of the Read trait to messages that can be deserialized (one for the two magic bytes, one for the schema fingerprint, and one for the actual message content). Each call to Read::read only returns the bytes of one chain link, so the first call to Read::read only returns 2 bytes.

Issue Links

• links to: GitHub Pull Request #1914