Avro
  1. Avro
  2. AVRO-363

TestSchema had two tests disabled; new test for named schemas named after primitives.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Two tests were marked private and therefore not executed in TestSchema. One of these passed easily; the other needed a bit of an implementation fix (throw an exception on mismatched enums, which I think is the currently spec'd behavior). I also added a test (and then fixed functionality) to prevent records (and other named schema types) to be named after primitive types.

      1. AVRO-363.patch
        5 kB
        Philip Zeyliger
      2. AVRO-363.patch
        5 kB
        Philip Zeyliger

        Activity

        Hide
        Philip Zeyliger added a comment -

        Committed. Thanks for the review, Doug.

        Show
        Philip Zeyliger added a comment - Committed. Thanks for the review, Doug.
        Hide
        Doug Cutting added a comment -

        +1 this looks good to me.

        Show
        Doug Cutting added a comment - +1 this looks good to me.
        Hide
        Philip Zeyliger added a comment -

        Previous patch was missing a couple of lines; oops.

        Show
        Philip Zeyliger added a comment - Previous patch was missing a couple of lines; oops.

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development