[AVRO-3475] Enforce time-millis and time-micros specification

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.11.1, 1.12.0
• Component/s: csharp
• Labels: pull-request-available
• Assignee: Zoltan Csizmadia
• Reporter: Zoltan Csizmadia
• Created: 29/Mar/22 11:59
• Updated: 03/May/22 21:19
• Resolved: 03/May/22 21:19

Description

During fixing AVRO-3471, I noticed that negative in/long values or negative TimeSpan values are allowed for time-millis and time-micros. https://avro.apache.org/docs/current/spec.html states that, it is supposed to be the number of us/ms after midnight 00:00:00. The following TimSpan values do not cause any overflow exceptions:

 

"-00:00:00.001"

"-999999.00:00:00"

 

1. This change should throw exceptions in cases where the code has not thrown exceptions before
2. OutOfRange exception message should be changed to `'time-millis/micros' value must be at least '00:00:00' and less than '1.00:00:00'.` to reflect the spec precisely

 

It might make sense to introduce this change only in 1.12.0, because of all the above changes

Issue Links

• links to: GitHub Pull Request #1626