Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-3387

Update BinaryDecoder to conform to C# standards

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 1.11.0
    • None
    • csharp

    Description

      1. Update XML Documentation
      2. Update spacing
      3. remove this.
      4. conform to naming
        1. ie: private readonly Stream stream
          should have the field renamed to _stream (refer to #3)
        2. don't use single letter parameters in methods
      5. AvroException is a very generic exception and we should use more specific exceptions
        1. InvalidDataException is specific to operations on data in System.IO
        2. EndOfStreamException is specific to using System.IO.Stream
      6. Delete commented code
      7. Use explicit types instead of var

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              KSchoonover Kyle Schoonover
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 50m
                  2h 50m