[AVRO-3387] Update BinaryDecoder to conform to C# standards

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.11.0
• Component/s: csharp
• Labels: pull-request-available

Language

C#

• Assignee: Unassigned
• Reporter: Kyle Schoonover
• Created: 11/Feb/22 00:03
• Updated: 08/Mar/22 21:52

Description

1. Update XML Documentation
2. Update spacing
3. remove this.
4. conform to naming
   1. ie: private readonly Stream stream
      should have the field renamed to _stream (refer to #3)
   2. don't use single letter parameters in methods
5. AvroException is a very generic exception and we should use more specific exceptions
   1. InvalidDataException is specific to operations on data in System.IO
   2. EndOfStreamException is specific to using System.IO.Stream
6. Delete commented code
7. Use explicit types instead of var

Issue Links

• links to: GitHub Pull Request #1535