Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: build, python
    • Labels:
      None
    1. AVRO-311.patch
      10 kB
      Doug Cutting
    2. AVRO-311-2.patch
      10 kB
      Daniel Lundin
    3. AVRO-311.patch
      10 kB
      Daniel Lundin

      Issue Links

        Activity

        Hide
        Doug Cutting added a comment -

        I had to change build.xml to:

        • set PYTHONPATH when running tests
        • build the interop data (or exclude that test, which requires it)

        I also changed the top-level BUILD.txt to mention the dependency on nose.

        Show
        Doug Cutting added a comment - I had to change build.xml to: set PYTHONPATH when running tests build the interop data (or exclude that test, which requires it) I also changed the top-level BUILD.txt to mention the dependency on nose.
        Hide
        Daniel Lundin added a comment -

        Reworked patch to run `nosetests` directly, rather than from setup.py. This means testing will still work if setuptools is missing.

        Show
        Daniel Lundin added a comment - Reworked patch to run `nosetests` directly, rather than from setup.py. This means testing will still work if setuptools is missing.
        Hide
        Daniel Lundin added a comment -

        nosetests seemingly only works as a test collector in setup.py when using setuptools.

        See also: http://somethingaboutorange.com/mrl/projects/nose/0.11.2/setuptools_integration.html

        Show
        Daniel Lundin added a comment - nosetests seemingly only works as a test collector in setup.py when using setuptools. See also: http://somethingaboutorange.com/mrl/projects/nose/0.11.2/setuptools_integration.html
        Hide
        Doug Cutting added a comment -

        I'm fine with switching to nose if folks prefer it. However when I apply this patch, after installing nose (on ubuntu, with 'sudo apt-get install python-nose') test fail with:

        test:
             [exec] /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'install_requires'
             [exec]   warnings.warn(msg)
             [exec] /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'test_suite'
             [exec]   warnings.warn(msg)
             [exec] usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
             [exec]    or: setup.py --help [cmd1 cmd2 ...]
             [exec]    or: setup.py --help-commands
             [exec]    or: setup.py cmd --help
             [exec] 
             [exec] error: invalid command 'nosetests'
        

        The 'nosetests' executable is on my path, and running it directly also fails, but with different messages.

        Show
        Doug Cutting added a comment - I'm fine with switching to nose if folks prefer it. However when I apply this patch, after installing nose (on ubuntu, with 'sudo apt-get install python-nose') test fail with: test: [exec] /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'install_requires' [exec] warnings.warn(msg) [exec] /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'test_suite' [exec] warnings.warn(msg) [exec] usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] [exec] or: setup.py --help [cmd1 cmd2 ...] [exec] or: setup.py --help-commands [exec] or: setup.py cmd --help [exec] [exec] error: invalid command 'nosetests' The 'nosetests' executable is on my path, and running it directly also fails, but with different messages.
        Hide
        Philip Zeyliger added a comment -

        Hi Daniel,

        My only hesitation with this patch is that adds another dependency to folks building AVRO, namely that of having nosetests installed. I think nosetests is LGPL, so we shouldn't be redistributing it, though it's a fine build dependency.

        If no one objects, I'll go ahead and commit this, since I much prefer nose to python's built-in unittest myself.

        Show
        Philip Zeyliger added a comment - Hi Daniel, My only hesitation with this patch is that adds another dependency to folks building AVRO, namely that of having nosetests installed. I think nosetests is LGPL, so we shouldn't be redistributing it, though it's a fine build dependency. If no one objects, I'll go ahead and commit this, since I much prefer nose to python's built-in unittest myself.
        Hide
        Daniel Lundin added a comment -

        Patch implements using nosetests to collect and run test from setup.py (and ant).

        Show
        Daniel Lundin added a comment - Patch implements using nosetests to collect and run test from setup.py (and ant).

          People

          • Assignee:
            Unassigned
            Reporter:
            Jeff Hammerbacher
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development