[AVRO-3044] Protocol Callback interface should have @AvroGenerated

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.10.1
• Fix Version/s: 1.10.2
• Component/s: java
• Assignee: Unassigned
• Reporter: Anatoly Kupriyanov
• Created: 12/Feb/21 21:45
• Updated: 05/Mar/21 15:44
• Resolved: 05/Mar/21 15:44

Description

This is very similar to AVRO-2298

The protocol has interface

 

@org.apache.avro.specific.AvroGenerated
public interface SomeProto {
  public static final org.apache.avro.Protocol PROTOCOL = .....

// here it should also have @AvroGenerated{{}}
  @SuppressWarnings("all")
  public interface Callback extends SomeProto {
  public static final org.apache.avro.Protocol PROTOCOL = com.my.SomeProto.PROTOCOL;
{

{  }

}}
}

 

 

This is the place in the code: https://github.com/apache/avro/blob/7d1e63b219e6d0778bc57195152477adee97fcab/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/protocol.vm#L64

 

Also as I see the $protocol.getDoc() javadoc should not be between interface and annotations, it breaks javadoc processing.

Issue Links

• links to: Pull Request