[AVRO-2976] IDL parsing does not support arbitrary logical types

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.2, 1.10.0, 1.9.2, 1.10.1, 1.10.2
• Fix Version/s: 1.11.1
• Component/s: java, logical types, tools
• Labels: pull-request-available
• Assignee: Oscar Westra van Holthe - Kind
• Reporter: Oscar Westra van Holthe - Kind
• Created: 13/Nov/20 09:46
• Updated: 12/Dec/21 05:56
• Resolved: 11/Dec/21 14:34

Description

When parsing Avro IDL in code, the resulting protocol types (schemas) have no logical types defined, when though the properties for them are set.

 

Example IDL:

protocol P {
	record R {
		@logicalType("timestamp-micros") long uTime;
	}
}

 

The following test fails on the second assert: 

@Test
public void validateIdlLogicalTypeParsing() {
  final ClassLoader cl = Thread.currentThread().getContextClassLoader();
  Idl idl = new Idl(cl.getResourceAsStream("logicalTypes.avdl"), "UTF-8");
  Protocol protocol = idl.CompilationUnit();

  Schema fieldSchema = protocol.getType("R").getField("uTime").schema();

  Assert.assertEquals("timestamp-micros", fieldSchema.getObjectProp("logicalType"));
  Assert.assertNotNull(fieldSchema.getLogicalType());
}

 

A minimal proof is attached.

Issue Links

• links to: GitHub Pull Request #985