Avro
  1. Avro
  2. AVRO-296

Extend Avro IDL (was genavro) to do "doc" fields

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5.1
    • Component/s: java
    • Labels:
      None

      Description

      AVRO-152 introduces docs in schemas; genavro should understand those as well.

      1. AVRO-296.patch
        6 kB
        Doug Cutting

        Issue Links

          Activity

          Hide
          Doug Cutting added a comment -

          I committed this.

          Show
          Doug Cutting added a comment - I committed this.
          Hide
          Philip Zeyliger added a comment -

          Thanks for this patch; I think it'll be a great boon.

          Patch looks good, but I didn't see a test. Do we have anything that can check that the docs are making their way in. I'm particularly curious to see how newlines and whitespace is being translated. That stuff is easy to get off by one, so would be worth testing.

          Show
          Philip Zeyliger added a comment - Thanks for this patch; I think it'll be a great boon. Patch looks good, but I didn't see a test. Do we have anything that can check that the docs are making their way in. I'm particularly curious to see how newlines and whitespace is being translated. That stuff is easy to get off by one, so would be worth testing.
          Hide
          Doug Cutting added a comment -

          Unless there are objections I'll commit this soon.

          Show
          Doug Cutting added a comment - Unless there are objections I'll commit this soon.
          Hide
          Doug Cutting added a comment -

          Here's a patch that implements this, including tests.

          Show
          Doug Cutting added a comment - Here's a patch that implements this, including tests.

            People

            • Assignee:
              Doug Cutting
              Reporter:
              Philip Zeyliger
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development